Ticket #8355 (closed: fixed)
Clear memory leaks in the KernelTest package
| Reported by: | Russell Taylor | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | #8359 | Tester: | Michael Reuter |
Description (last modified by Peter Peterson) (diff)
The SNS Jenkins has a valgrind job which uses the unit tests as a hook into exercising the Mantid code itself. This of course means that it picks up any leaks in the test code as well.
Using this job and/or valgrind runs of your own, reduce the leaks/errors that come out of the test code itself. I've created this as an isolated ticket because I'd like to get a clear view of the errors we have in the actual Mantid code. All changes to this ticket should only be to code in the Framework/Kernel/test/ directory!
Change History
comment:2 Changed 7 years ago by Peter Peterson
- Status changed from new to inprogress
- Owner set to Peter Peterson
comment:4 Changed 7 years ago by Peter Peterson
Re #8355. Got rid of memory leak in a test.
Changeset: f6e5c8694a269d353d7e5612d430d4faf8296a2e
comment:5 Changed 7 years ago by Peter Peterson
Re #8355. Check for null pointer in Logger::shutdown
Changeset: d78d1c638b4c9f5aa64f57b43334cc376c4e35d3
comment:6 Changed 7 years ago by Peter Peterson
Re #8355. Added a helper that will cleanup the logger on test exit.
Changeset: 6b4d93f352711f834e4021b16b269588dd67e02f
comment:7 Changed 7 years ago by Peter Peterson
Re #8355. Plugged memory leaks in DynamicFactory.
Changeset: a2855454817ff18acc80c84cb525ac47ba2d6dd7
comment:9 Changed 7 years ago by Peter Peterson
Re #8355. Plugging memory leaks in LogParser.
Changeset: d378472e9069e1a8ef83e79ed0bd3e4d2dd7fa9c
comment:10 Changed 7 years ago by Peter Peterson
Re #8355. Undoing some changes to Logger.cpp
Changeset: b738dcb4ff03ff901b0cb9c9d1b313150efe0f1a
comment:11 Changed 7 years ago by Peter Peterson
Re #8355. Fixed more memory leaks in the tests.
Changeset: 62853fce15de7d3ff5db95894e105e5154bf0fb3
comment:12 Changed 7 years ago by Peter Peterson
Re #8355. Adding valgrind suppressions for KernelTest.
Changeset: e0767716391c4eb201d659d934595b1a1aa41c00
comment:13 Changed 7 years ago by Peter Peterson
Merge remote branch 'origin/master' into feature/8355_kernel_memory
Conflicts:
Code/Mantid/Framework/Kernel/test/LogParserTest.h
Re #8355.
Changeset: 67b734f87c1d0641a2e5f1d4cb60357360b2d0e8
comment:14 Changed 7 years ago by Peter Peterson
Re #8355. Fixing the builds.
Changeset: 6b5066ae015826d0ead551fc942f1100e083344c
comment:15 Changed 7 years ago by Peter Peterson
Re #8355. Adding some of the deletes back.
Changeset: 8b89b4194b83350f6ae151db39c0301b2a8e1f3d
comment:16 Changed 7 years ago by Russell Taylor
Re #8355. Remove a line that causes a crash on the next test.
This stopped a direct run of KernelTest from working - it would crash in TimeSeriesPropertyTest.
Changeset: a54f34303774d7173c1e84a5accc34e9e8617286
comment:17 Changed 7 years ago by Russell Taylor
Re #8355. Use Poco memory management mechanism (Poco::AutoPtr).
Changeset: 87b2600212d31d18387402cfd2bc91f5114a5b68
comment:20 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/8355_kernel_memory
Look and see that ornl_valgrind_develop has the chart go down a little. There are still lots of leaks, but this is a start.
comment:21 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:22 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8355_kernel_memory'
Full changeset: 0a90dcb196b22824ba5f13866bea48a50ee1c040
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9200
