The SINQ library depends on CurveFitting when it shouldn't

[Russell Taylor]

In the mantid-mpi build 3.0 release (as deployed on fermi at ORNL), every time you start up Mantid you see the following message:

Error DllOpen - Could not open library /sw/fermi/mantid-mpi/mantid-mpi-3.0.0-1.el6.x86_64/plugins//libMantidSINQ.so: libMantidCurveFitting.so: cannot open shared object file: No such file or directory

This is because plugin libraries are not allowed to depend on other plugin libraries. We don't use rpaths for this build, which is why it shows up here and not elsewhere. I think no functionality is actually broken (as CurveFitting will be loaded in its own right anyway), but the message is unfortunate.

[Martyn Gigg]

Remove CurveFitting dependency in SINQ library.

The constraints are now created using the factory in API rather than linking directly. Refs #8364

Changeset: 9a793bf0b3f903dafc046c48f44de997a0773ed7

[Martyn Gigg]

Branch: bugfix/8364_rm_sinq_curvefit_depends

Tester: After merging the branch & building the code you should find that the MantidSINQ library has no dependency on CurveFitting. On Windows you can use Dependency walker, on Linux you can do ldd bin/libMantidSINQ.so}} or on Mac you can use {{{otool -L bin/libMantidSINQ.dylib to check the linked libraries. CurveFitting should not appear in the list.

[Owen Arnold]

Merge remote-tracking branch 'origin/bugfix/8364_rm_sinq_curvefit_depends'

Full changeset: ​a64e2bc25d68d66fea5ebcaeb2653f86939f04d8

[Stuart Campbell]

This ticket has been transferred to github issue ​9209