Ticket #8418 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

cppcheck portability and performance warnings

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.1
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: #8437 Tester: Samuel Jackson

Description


Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to inprogress

re #8418 cppcheck prefomance&style

Changeset: 4b9632e5a3adca43e8b5c96f255825cfb0f40e11

comment:2 Changed 7 years ago by Nick Draper

re #8418 cppcheck style

Changeset: 3416502b1b96c52e7217c86b407415bf5b9f3212

comment:3 Changed 7 years ago by Nick Draper

re #8418 cppcheck style

Changeset: 3416502b1b96c52e7217c86b407415bf5b9f3212

comment:4 Changed 7 years ago by Nick Draper

re #8418 resolve a couple of errors

Changeset: f35472bc9942be18f03e88af90151968796b932f

comment:5 Changed 7 years ago by Nick Draper

re #8418 resolve warnings by fixing qtiplot code that never worked

Changeset: f5ce7cec90bbea3914c1b863ba612b9a877e35c4

comment:6 Changed 7 years ago by Nick Draper

re #8418 resolve warnings by fixing qtiplot code that never worked

Changeset: a8bc0f30a0a9cf09d4f951d1c0219b06efe109f9

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  1. check build on develop have passed, and unit tests pass

​http://download.mantidproject.org/jenkins/job/is_inc_ubuntu-12.04_develop/2555/

  1. code review

comment:8 Changed 7 years ago by Nick Draper

  • Blocking 8437 added

(In #8437) NOTE TO TESTER: Ticket #8418 must be tested and merged before this ticket.

comment:9 Changed 7 years ago by Nick Draper

  • Blocking 8437 removed

(In #8437) To test:

  1. FIRST test and Merge #8418
  2. Check the code builds and passes unit tests

​http://download.mantidproject.org/jenkins/job/is_inc_rhel6_develop/2722/ The warning here was cleared by the last commit

  1. Code review - although there is a lot to go through
  2. After merging the number of cppcheck stlye errors should reduce - it will not reach 0

comment:10 Changed 7 years ago by Nick Draper

  • Blocking 8437 added

comment:11 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:12 Changed 7 years ago by Samuel Jackson

I'm getting merge conflicts when attempting to test this. Fix and I'll re-verify.

comment:13 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:14 Changed 7 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #8418 merge confilcts

Changeset: d045261536761b95a8f5cdd2aedfc2c2126f7d6e

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:16 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying

comment:17 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8418_cppcheck_performance'

Full changeset: ​fa150e13f92c0d2a88d2f9a5aca8e66239d64fb5

comment:18 Changed 7 years ago by Samuel Jackson

Tests are passing and the code looks good.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9262

Note: See TracTickets for help on using tickets.