Ticket #8489 (closed: fixed)
Fix unreleased use of POCO::XML document and nodelists in Kernel code
| Reported by: | Karl Palmen | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | maintenance |
| Cc: | Blocked By: | ||
| Blocking: | #8359, #10637 | Tester: | Peter Parker |
Description (last modified by Karl Palmen) (diff)
In the code of framework/Kernel I found a few cases of POCO::XML document or nodelist objects being created, but not released. This could cause memory leakage. Fix by using AutPtr for the object.
Change History
comment:4 Changed 7 years ago by Russell Taylor
- Owner set to Russell Taylor
- Blocking 8359 added
- Milestone changed from Backlog to Release 3.2
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Seems like I referenced the wrong ticket in all the commits for this - Oops!
Anyway, the branch nunmber is right: https://github.com/mantidproject/mantid/tree/bugfix/8459_poco_xml_leaks
To test:
- Check that there are no more calls to the release() method in Kernel code (grep is your friend). Note that there is one call to a completely different release() method related to the logger.
- See an absence of Kernel memory leaks here: https://builds.sns.gov/view/Static%20Analysis/job/ornl_valgrind_develop/valgrindResult/
- See that otherwise all builds and tests are passing.
comment:6 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:7 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
The Kernel code is now leak-free and all tests passed.
comment:8 Changed 7 years ago by Peter Parker
Merge remote-tracking branch 'origin/bugfix/8459_poco_xml_leaks'
Full changeset: 98845ef6c0c7ac9329e3fc764431bd1844d253a9
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9333
Note: See
TracTickets for help on using
tickets.
