Fix unreleased use of POCO::XML document and nodelists in MD code

[Karl Palmen]

In the code of framework/MDAlgorithms and framework/MDEvents I found some cases of POCO::XML document or nodelist objects being created, but not released. This could cause memory leakage. Fix by using AutPtr for the object.

The cases I found were:

MDAlgorithms InvalidParameterParser, Vector3DParameterParser, BinMDTest, InvalidParameterParserTest

MDEvents AffineMatrixParameterParser, CoordTransformAffineParser, CoordTransformDistanceParser and unit tests

[Gesner Passos]

it seems that the following inclues are not used in Mantid/Framework/MDAlgorithms/src/BinMD.cpp

#include <Poco/DOM/Document.h>
#include <Poco/DOM/DOMParser.h>
#include <Poco/DOM/Element.h>

[Nick Draper]

bulk move to assigned at the into of the triage step

[Federico Montesino Pouzols]

Use Poco::AutoPtr, get rid of old poco includes, re #8491

Changeset: cea958b2ea5a10457f1feb4b841a029786887e9e

[Federico M Pouzols]

This removes potential leaks with Poco::XML objects (following guidelines in #10637), a bunch of not needed includes have been removed (using forward declarations wherever possible). It seems that some of the issues have been fixed since this ticket was reported. The pieces modified here are (not counting removal of unnecessary headers):

• Algorithms: InvalidParameterParserTest
• Events: CoordTransformAffineParser. CoordTransformDistanceParser

Suggestion to test:

• check that builds are fine on all platforms (apparently no issue here)
• review code
• make sure that (MD) tests pass

[Martyn Gigg]

There are some merge conflicts with master, which I think are due to the mass format with clang-format. I would suggest running clang-format on the files changed in the branch and then merging master into the branch.

It will then need to be put back on develop

[Federico Montesino Pouzols]

clang-format them to fix conflict issues, re #8491

Changeset: 2059c3d27b5d024b2d56a875f3456fc35cf2495b

[Federico M Pouzols]

I think it should be fine and conflict-free this time.

[Martyn Gigg]

Merge branch 'bugfix/8491_fix_unreleased_poco_xml_objects_MD'

Conflicts:

Code/Mantid/Framework/MDAlgorithms/inc/MantidMDAlgorithms/Vector3DParameterParser.h Code/Mantid/Framework/MDEvents/src/CoordTransformAffineParser.cpp Code/Mantid/Framework/MDEvents/src/CoordTransformDistanceParser.cpp

Full changeset: ​4603100bb5dfca1993879da5101b5a3f6811678f

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​9335