Ticket #8495 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Input checking in CalibrateRectangularDetector

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.2
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

With the "CrossCorrelate" option turned on, verify that there is appropriate number of peaks specified (one unless the splitting option is used).

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Comment Deleted: Wrong Ticket number on commit

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:2 Changed 7 years ago by Peter Peterson

  • Blocked By 8979 added

comment:2 Changed 7 years ago by Peter Peterson

  • Blocked By 8979 removed
  • Milestone changed from Backlog to Release 3.2

comment:4 Changed 7 years ago by Peter Peterson

Re #8495. Changed call for logging.

Changeset: e68b0d305cf489ddb54d97932c5ae3ce91ce3ead

comment:5 Changed 7 years ago by Peter Peterson

Re #8495. Implemented CalibrateRectangularDetector.validateInputs

Changeset: aee97dbbcadbbcc4d96df2aa922b59fffea6f0a3

comment:6 Changed 7 years ago by Peter Peterson

Merge branch 'feature/8495_in_check_CalibrateRectangularDetector' into develop

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/CalibrateRectangularDetectors.py

Re #8495

Changeset: cc94c24d0c6eaf8ec8959e053d2685d72719e74f

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is in ​feature/8495_in_check_CalibrateRectangularDetector.

To test: Try running CalibrateRectangularDetectors with different values for:

  • CrossCorrelation
  • PeakPositions
  • DetectorPeaks

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

This broke a ​system test

comment:9 Changed 7 years ago by Peter Peterson

  • Status changed from reopened to inprogress

Re #8495. Fixing bug in comparing length of arrays.

Changeset: 2875f99eb2d33d428df9383d3a63bf93fccb69ce

comment:10 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Same testing information as comment:7.

comment:11 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:12 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8495_in_check_CalibrateRectangularDetector'

Full changeset: ​e485b3a58dbc309ca57bfab20a233034297d09c2

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9339

Note: See TracTickets for help on using tickets.