Ticket #8496 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveHKL with no sample material

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.1
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

If there isn't a sample material (and the coefficients aren't set) that tbar and transmission in the file are just zeros

Change History

comment:1 Changed 7 years ago by Vickie Lynch

  • Status changed from new to inprogress

Refs #8496 skip absorption if no material or input parameters

Changeset: d2f705662da3aeab798ee368f8f8d72ba361ba1c

comment:2 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

If you run SaveHKL on the same PeaksWorkspace twice it grabs all sorts of neutronic information. 

Sample number density = 1 atoms/Angstrom^3
Cross sections for wavelength = 1.7982Angstroms
    Coherent = 8.98847e+307 barns
    Incoherent = 0 barns
    Total = 8.98847e+307 barns
    Absorption = 8.98847e+307 barns
SaveHKL successful, Duration 0.19 seconds

comment:5 Changed 7 years ago by Vickie Lynch

  • Status changed from reopened to inprogress

Refs #8496 need one more if test

Changeset: 7c11eb9c525e80fc8a1fdc0b06fb3e28ace4fe4c

comment:6 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

Fixed problem found by tester

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from verify to closed

Merge remote branch 'origin/feature/8496_SaveHKL_noSample'

Full changeset: ​23b7c4fd384d088cca56c638767e859fff2d9283

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9340

Note: See TracTickets for help on using tickets.