Ticket #8501 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Better error message if lsb_release is missing

Reported by: Peter Peterson Owned by: Russell Taylor
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

Joachim Wutke reported this error when lsb_release is missing (like on debian):

-- Found the following Boost libraries:
--   date_time
--   regex
CMake Warning (dev) at Build/CMake/LinuxSetup.cmake:4 (find_package):
   Syntax Warning in cmake code at

/home/jwu/g/othersw/mantid-3.0.0-Source/Build/CMake/FindPythonLibs.cmake:65:34

   Argument not separated from preceding token by whitespace.
Call Stack (most recent call first):
   Build/CMake/CommonSetup.cmake:222 (include)
   CMakeLists.txt:78 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

--  DIST:  CODENAME:
CMake Error at Build/CMake/LinuxSetup.cmake:93 (if):
   if given arguments:

     "STREQUAL" "RedHatEnterprise"

   Unknown arguments specified
Call Stack (most recent call first):
   Build/CMake/CommonSetup.cmake:222 (include)
   CMakeLists.txt:78 (include)


-- Configuring incomplete, errors occurred!
See also
"/home/jwu/g/othersw/mantid-3.0.0-Source/CMakeFiles/CMakeOutput.log".
See also
"/home/jwu/g/othersw/mantid-3.0.0-Source/CMakeFiles/CMakeError.log".

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress
  • Milestone changed from Backlog to Release 3.2

comment:3 Changed 6 years ago by Russell Taylor

Re #8501. Fix CMake error if string variables are empty.

Changeset: 77209235ab9d1cbc6864a22cae6351f38808b408

comment:4 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test (needs to be on Linux): If you happen to be on debian it's easy - before the cmake step fails, after it completes. Otherwise, the way to mimic it is to edit Mantid/Build/CMake/FindLinuxDistrocmake to always set UNIX_DIST, UNIX_CODENAME & UNIX_RELEASE to empty strings at the end.

comment:5 Changed 6 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:6 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8501_cmake_error_if_lsb_release_missing'

Full changeset: 58a75a8c7edde3892aff7759cd51effb22b76454

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9345

Note: See TracTickets for help on using tickets.