Ticket #8502 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Refactor IndexingUtils

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.1
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

CompareMagnitude should be in V3D CheckUB should use matrix's determinate function Move GetUB to OrientedLattice Move GetABS to OrientedLattice GetLatticeParameters should just use OrientedLattice GetLatticeParameterString should use OrientedLattice Niggli cell stuff should subclass either OrientedLattice or UnitCell

Change History

comment:1 Changed 7 years ago by Vickie Lynch

  • Status changed from new to inprogress

Refs #8502 first four refactor tasks

Changeset: 94f8ba826ddfddd2f817dac0e48cf43c1aaa4586

comment:2 Changed 7 years ago by Vickie Lynch

Refs #8502 rest of refactor tasks

Changeset: 82f7899853d96a9a57aca3a3351d1c7a25c870c5

comment:3 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test, check that indexing peaks still works

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 7 years ago by Owen Arnold

This refactoring looks great, but I'm going to wait for a clean-build + system test run because the behaviour here is fundamental to how a log of the single crystal reduction works.

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8502_refactor_indexing'

Full changeset: ​923f3e483c2bb8ee1abcef900cfa4ae230c748a7

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9346

Note: See TracTickets for help on using tickets.