Ticket #8516 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix l2q instrument setup usage

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

l2q.py is hard-coded with an instrument reference frame for the MoveComponent correction calculations.

For instruments that do not share the same reference frame, the calculation will yield completely different and incorrect results.

Use the ReferenceFrame type associated with the instrument to correctly apply the corrections without having to know the specifics of the instrument setup.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Milestone changed from Backlog to Release 3.1

Commit made against 8561 rather than 8516. Here it is:

​https://github.com/mantidproject/mantid/commit/8458919e943304491225cb4bed9d840f58b04576

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8516. Missing header changes.

Changeset: 6b368f4b6dc2a982014fec71cba9efb9b4e49ae3

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Owen Arnold

Tester:

Check unit tests are running then follow same test instructions for #8372

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8516_reference_frame'

Full changeset: ​6528ec0bd86c8759eef9b7675eabcd7ef9c1b260

comment:7 Changed 7 years ago by Gesner Passos

Added flexibility and is working correctly.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9360

Note: See TracTickets for help on using tickets.