Ticket #8515 (closed: fixed)
LoadNexusProcessed is creating two names in ADS for workspaces in a group with a custom name
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
It looks like the workspaces are being added with a default name (Parent_n) then re-added with their more verbose name.
Change History
comment:1 Changed 7 years ago by Samuel Jackson
- Summary changed from LoadNexusProcessed is creating two names in ADS for workspaces with a custom name to LoadNexusProcessed is creating two names in ADS for workspaces in a group with a custom name
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #8515 Change algorithm to store group workspaces second.
Changeset: e56bd88cd6c01acef3a4b9a9c306e9e5cb21492b
comment:3 Changed 7 years ago by Samuel Jackson
Refs #8515 Updated workspace names to match in LoadMcStasTest
Changeset: 135e6108f56bce75c765ad217e138908fd23cb58
comment:4 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
This issue was caused by the group workspaces with children with custom names being re-added to the ADS with their proper name after being added with a default name. The solution in this ticket adds all of the children of the group workspace first, then the groups themselves.
I believe this ticket is also a duplicate of #8269
To Test:
First, check that the system tests are all passing. Try loading a group workspace with custom names into Mantid. A good example test file would be mcstas_event_hist.h5 from the AutoTestData. Use the IPython console and run mtd.getObjectNames() and check that you have the same number of workspaces as expected and that they are called the same thing in the ADS as listed on the interface.
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
When a group work space is loaded there are no longer any double references to workspace. I verified this in IPython (as suggested), when the workspaces were ungrouped and when they were deleted (as noted in #8269).
comment:7 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/bugfix/8515_LoadNexusProcessed_group_names'
Full changeset: 4a5ee5cacdf4fb0d98434572a888dff03da1ada2
