Context Navigation

Ticket #8514 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Critical System Test Coverage for ReflGui + Quick (SURF)

Reported by:	Owen Arnold	Owned by:	Keith Brown
Priority:	critical	Milestone:	Release 3.1
Component:	Reflectometry	Keywords:
Cc:		Blocked By:
Blocking:	#7377	Tester:	Owen Arnold

Description (last modified by Keith Brown) (diff)

Take the table files provided by Max for the Reflectometry GUI corresponding to test runs for each reflectometry instrument (ask me for these)
Firstly run each one through the reflectometry gui and check that you receive sensible I vs Q plots for each one (these should just work)
If the there were any problems in the previous step, it's probably due to missing instrument parameters, which we will need to add.
Using the attached python script as a reference (taken from existing system tests for INTER), turn each table into a separate system test

We should then have very good test coverage over the back-end scripts for the reflectometry GUI.

This ticket is for the SURF instrument, due to delays POLREF and CRISP have their own separate tickets: CRISP is in #8530, POLREF is in #8529

Attachments

ReflectometryQuick.py (1.1 KB) - added by Owen Arnold 7 years ago.

Change History

Changed 7 years ago by Owen Arnold

Attachment ReflectometryQuick.py added

comment:1 Changed 7 years ago by Keith Brown

Blocked By 8523 added

comment:1 Changed 7 years ago by Keith Brown

Blocking 7377 added
Blocked By 8523 removed

comment:2 Changed 7 years ago by Keith Brown

Blocked By 8523 added

comment:3 Changed 7 years ago by Keith Brown

Status changed from new to inprogress

comment:4 Changed 7 years ago by Keith Brown

Blocked By 8527 added

comment:5 Changed 7 years ago by Keith Brown

Blocked By 8523, 8527 removed

#8523 and #8527 no longer block as checks have been done (and finer tests will be done by scientists) and the POLREF issue is being delegated to another ticket while we wait

comment:7 Changed 7 years ago by Keith Brown

Refs #8514 removed quick script case for loaded in ADS or not

There was a section in the quick script that shouldn't have been there as it was doing different thigns depending if the ADS had a workspace or not.

It is now only using the case as if it wasn't in the ADS in order to avoid a Divide error.

Changeset: 173b7e1569213a0fa31c60c1021d0e78b86ae267

comment:8 Changed 7 years ago by Keith Brown

Refs #8514 Added SURF Test

Added the SURF Reflectonomy test and the ReferenceResult asscociated with it

Changeset: ba03b012ba7911ff26e1f745d0d86f0151ae0383

comment:9 Changed 7 years ago by Keith Brown

Refs #8514 Removed comment, renamed class

Renamed the class to be the same as the filename

Removed a comment

Changeset: 224f5f3c810de34f5e2b0108d0d8fe8c16e636c2

comment:10 Changed 7 years ago by Keith Brown

Status changed from inprogress to verify
Resolution set to fixed
Description modified (diff)
Summary changed from Critical System Test Coverage for ReflGui + Quick to Critical System Test Coverage for ReflGui + Quick (SURF)

This ticket is now just for the SURF instrument test, due to delays POLREF and CRISP will have their own separate tickets as i lack an up to date IDF for POLREP and data to test with for CRISP

comment:11 Changed 7 years ago by Keith Brown

Description modified (diff)
Milestone changed from Backlog to Release 3.1

comment:12 Changed 7 years ago by Keith Brown

Refs #8514 Fix SURF System Test

The test had a couple of problems, a syntax error where I'd forgotten a colon and the lack of date in the Data Directory for it to perform the opperation on.

Both are now fixed

Changeset: ed4f3615c1c6862659a7b5f145e3c7e886ca9f98