Ticket #7377 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

Refl_gui Improvements

Reported by: Owen Arnold Owned by: Keith Brown
Priority: major Milestone: Release 3.1
Component: Reflectometry Keywords: Student
Cc: nick.draper@… Blocked By: #8475, #8514, #8522, #8523, #8531, #8532, #8549, #8560, #8577, #8584, #8590, #8620, #8633, #8691, #8693, #8721, #8733, #8750, #8756, #8763, #8765, #8788, #8826
Blocking: #8692 Tester: Jay Rainey

Description (last modified by Nick Draper) (diff)

The Ref gui no longer has a *.ui file, which is starting to make it a maintenance nightmare. We need to reverse engineer a ui file out of the python code.

We've been handed the GUI code, so we don't have all the expertise for all the options this GUI provides within the team, but Max would be more than happy to help us discover the options, as he was the original author. Once the GUI has been reverse engineered, we can explore making it more useable and professional looking, but we need to replicate the existing behaviour first.

See Owen Arnold for details.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Description modified (diff)

comment:2 Changed 7 years ago by Owen Arnold

  • Cc nick.draper@… added

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:4 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Keith Brown
  • Milestone changed from Backlog to Release 3.0

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Reflectometry
  • Description modified (diff)

comment:6 Changed 7 years ago by Keith Brown

  • Milestone changed from Release 3.0 to Backlog

comment:7 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress
  • type changed from enhancement to task
  • Milestone changed from Backlog to Release 3.1

This is such a monumental job, it's being split into multiple tickets, the first leg of which will be to simply replicate the original in QtDesigner

comment:8 Changed 7 years ago by Keith Brown

  • Blocked By 8475 added

comment:9 Changed 7 years ago by Keith Brown

  • Blocked By 8522 added

comment:10 Changed 7 years ago by Keith Brown

  • Blocked By 8523 added

comment:11 Changed 7 years ago by Keith Brown

  • Blocked By 8514 added

comment:12 Changed 7 years ago by Keith Brown

  • Blocked By 8529 added

comment:13 Changed 7 years ago by Keith Brown

  • Blocked By 8530 added

comment:14 Changed 7 years ago by Keith Brown

  • Blocked By 8531 added

comment:15 Changed 7 years ago by Keith Brown

  • Blocked By 8532 added

comment:16 Changed 7 years ago by Keith Brown

  • Blocked By 8549 added

comment:17 Changed 7 years ago by Keith Brown

  • Blocking 8551 added

comment:18 Changed 7 years ago by Keith Brown

  • Blocked By 8560 added

comment:19 Changed 7 years ago by Keith Brown

  • Blocked By 8577 added

comment:20 Changed 7 years ago by Keith Brown

  • Blocked By 8590 added

comment:21 Changed 7 years ago by Keith Brown

  • Blocked By 8620 added

(In #8620) Linked it to the main gui work by setting to to block #7377

The functionality actualy already works, it's just that it silently does nothing when the run number isn't present in the row below. So this has changed to making the function more vocal.

comment:22 Changed 7 years ago by Keith Brown

  • Blocked By 8633 added

comment:23 Changed 7 years ago by Keith Brown

  • Blocked By 8584 added

comment:24 Changed 7 years ago by Keith Brown

  • Blocked By 8693 added

comment:25 Changed 7 years ago by Keith Brown

  • Blocking 8692 added

comment:26 Changed 7 years ago by Keith Brown

  • Blocked By 8691 added

comment:27 Changed 7 years ago by Keith Brown

  • Blocked By 8721 added

comment:28 Changed 7 years ago by Keith Brown

  • Blocked By 8733 added

comment:29 Changed 7 years ago by Keith Brown

  • Blocked By 8750 added

comment:30 Changed 7 years ago by Keith Brown

  • Blocking 8551 removed

(In #8551) Owen didn't see that I already created this ticket, so I'll deem this duplicate as his one (#8756) is more descriptive.

comment:31 Changed 7 years ago by Keith Brown

  • Blocked By 8763 added

comment:32 Changed 7 years ago by Keith Brown

  • Blocked By 8756 added

(In #8756) To Tester:

Follow the instructions on the pages.

You should be aware that I have an Autistic Spectrum Disorder and have some problems with wording things sometimes, so special attention should be paid to the spelling, grammar, possible alternative interpretations, and inferences made in the writing. I have used assistive software to help me, but things can slip through.

comment:33 Changed 7 years ago by Keith Brown

  • Blocked By 8765 added

(In #8765) Linking 7377 to this ticket

comment:34 Changed 7 years ago by Keith Brown

  • Blocked By 8530 removed

(In #8530) 7377 isn't directly related to this. And these system tests can be done in maintenance.

comment:35 Changed 7 years ago by Keith Brown

  • Blocked By 8529 removed

(In #8529) 7377 isn't directly related to this. And these system tests can be done in maintenance.

comment:36 Changed 7 years ago by Keith Brown

  • Blocked By 8787 added

comment:37 Changed 7 years ago by Keith Brown

  • Blocked By 8788 added

comment:37 Changed 7 years ago by Keith Brown

  • Blocked By 8788 removed
  • Summary changed from Ref_gui to Refl_gui Improvements

There are no code changes against this ticket, this was grouping all the work done to it. Build a fresh copy of master to test this.

To Tester

Go through each of the tickets that were blocking this one and make sure their fixes haven't been broken by subsequent tickets.

Make sure all the features of the Reflectometry gui still work as per these docs.

Note that there are some features that we know don't work and will be fixed up next release. #8814 was opened to deal with a type problem The 3-column export format hasn't been implemented Spectra list definition when exporting hasn't been implemented

comment:38 Changed 7 years ago by Keith Brown

  • Blocking 8788 added

(In #8788) Should still block #7377

comment:39 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:40 Changed 7 years ago by Owen Arnold

  • Blocking 8788 removed

(In #8788) This isn't blocked by 7377, (although it may be blocking 7377) as 7377 is blocked by 8787, which has nothing to do with this feature.

comment:41 Changed 7 years ago by Keith Brown

  • Blocked By 8788 added

(In #8788) Yeah, my mistake, but the number in the wrong blocker field

comment:42 Changed 7 years ago by Keith Brown

  • Milestone changed from Backlog to Release 3.1

Still valid for this release. This is a parent ticket so that the entire interface can be tested once other features are verified separately.

comment:43 Changed 7 years ago by Keith Brown

  • Blocked By 8787 removed

(In #8787) In which case I'll stop it blocking 7377 as that's just for the old gui

comment:44 Changed 7 years ago by Keith Brown

  • Blocked By 8826 added

comment:45 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

All linked tickets are now fixed. Can the tester please refer to comment:37 for how to test this ticket.

comment:46 Changed 7 years ago by Keith Brown

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:47 Changed 7 years ago by Keith Brown

  • Status changed from reopened to verify
  • Resolution set to invalid

Rather than "fixed" it's now invalid as all the work is done but not on this ticket. Me and Owen will do unscripted testing on it.

comment:48 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:49 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

No changes were made in this ticket, and testing of the GUI will be addressed separately as noted in comment:47. Closing as invalid.

comment:50 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8223

Note: See TracTickets for help on using tickets.