Ticket #8721 (closed: duplicate)

Opened 7 years ago

Last modified 5 years ago

Refl_gui Improvements - Fix Instrument Selection

Reported by: Keith Brown Owned by: Keith Brown
Priority: blocker Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #7377 Tester: Owen Arnold

Description (last modified by Keith Brown) (diff)

Max has reported that the Instrument selection combobox on the gui isn't working right and changes the instrument to a number. This is most likely because of the way pyqt handles overloaded signals.

I need to change the signal to specifically use the string overload rather than the integer overload.

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress
  • Description modified (diff)

comment:2 Changed 7 years ago by Keith Brown

  • Blocking 8560 added

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to duplicate

This ticket is actually a dupe of #8560 as i'd forgotten that I'd already fixed this problem in that ticket, albeit in a different way

comment:4 Changed 7 years ago by Keith Brown

  • Blocking 8560 removed

(In #8560) This ticket actually fixes the problem from 8721 as well

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 7 years ago by Owen Arnold

Needs a checkbuild before I can test it.

comment:7 Changed 7 years ago by Keith Brown

No it doesn't. this had no commits against it. This was marked duplicate and just needs confirming that the fix this was going to do was done in #8560

comment:8 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9565

Note: See TracTickets for help on using tickets.