Ticket #8526 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add Vanadium reference for LoadILL

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 3.1
Component: Framework Keywords: ILL Loader LoadILL
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

For e.g. helium mesurements, the dispersion peak is much higher than the elastic peak, thus the Loader failed to find the elastic peak position (EPP).

The solution can be an optional vanadium dataset where the the loader will look for the EPP.

Change History

comment:1 Changed 7 years ago by Ricardo Leal

  • Status changed from new to inprogress

Re #8526 Working version. accepts vana.

Changeset: a2607bee82abdcfed4bcf110a55216f6bf725192

comment:2 Changed 7 years ago by Ricardo Leal

Re #8526 Cleaning up before closing the ticket.

Changeset: 355be9efe880fcc83334d7bf30f356f0db497fe2

comment:3 Changed 7 years ago by Ricardo Leal

Re #8526 System Test for ILL laoder with/without Vanadium.

Changeset: 62e4f9a6acb37278f967859122a3607a13eb6987

comment:4 Changed 7 years ago by Ricardo Leal

To test:

Algorithm: LoadILL (Just load should also work).

There are 2 files in the systemtests repository (Data Folder): 

Data/ILLIN5_Sample_096003.nxs
Data/ILLIN5_Vana_095893.nxs
  1. Loading the ILLIN5_Sample_096003.nxs and ConvertUnits to DeltaE the Elastic Peak is not aligned as the dispersion peak is stronger that the elastic.
  1. Loading Data/ILLIN5_Sample_096003.nxs as the sample and Data/ILLIN5_Vana_095893.nxs as Vanadium, and ConvertUnits to DeltaE the Elastic Peak should be alligned at E=0.

There is also a system test for testing this: 

SystemTests/AnalysisTests/LoadILLIN5Test.py
Last edited 7 years ago by Ricardo Leal (previous) (diff)

comment:5 Changed 7 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Ricardo Leal

  • Status changed from verify to reopened
  • Resolution fixed deleted

Reopen : Try to improve loading time.

comment:7 Changed 7 years ago by Ricardo Leal

  • Status changed from reopened to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.1

Couldn't get much improvement on the processing time. Leaving it as it was before.

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:9 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8526_vana_ref_in_LoadILL'

Full changeset: ​db0031bdf2dbd10796999c11198385ec9086df4d

comment:10 Changed 7 years ago by Samuel Jackson

Merge remote-tracking branch 'origin/feature/8526_vana_ref_in_LoadILL'

Full changeset: ​662782ea98e7614785377e53c4a923304674b96b

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9370

Note: See TracTickets for help on using tickets.