Ticket #8528 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SANS support slicing event mode data

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.1
Component: SANS Keywords:
Cc: peter.parker@… Blocked By: #8505, #8548
Blocking: #8535 Tester: Peter Parker

Description


Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Owner set to Gesner Passos
  • Component changed from Framework to SANS
  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Gesner Passos

  • Blocked By 8505 removed

(In #8505) There was a considerable work in this ticket. So, I decided to split it, in order to help the tester to follow what was done and test this ticket.

comment:3 Changed 7 years ago by Gesner Passos

  • Blocked By 8505 added

comment:4 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:5 Changed 7 years ago by Gesner Passos

The following script slices the input workspace before applying the reduction.

import ISISCommandInterface as i    
reload(i)
MASKFILE = FileFinder.getFullPath('MaskSANS2DReductionGUI.txt')

i.SANS2D()
i.MaskFile(MASKFILE)
i.AssignSample('22048')
i.AssignCan('22023')
i.SetEventSlices("0:300:450")
red = i.WavRangeReduction()

comment:6 Changed 7 years ago by Gesner Passos

  • Blocking 8535 added

comment:7 Changed 7 years ago by Gesner Passos

The user defined that we must not slice the can, only the sample.

comment:8 Changed 7 years ago by Gesner Passos

re #8528: TDD for processing time slices definition

Changeset: c047c488f5e06d854c7240de6052f897dad6f1b5

comment:9 Changed 7 years ago by Gesner Passos

re #8528: Extends Reducer to support slicings

Changeset: c50811f61f76f699231261bb0f1acaaabeb2cf48

comment:10 Changed 7 years ago by Gesner Passos

re #8528: Methods to slice event workspaces

Changeset: 5c1603e5514031fe7d204dbb7ff7013483a46ea1

comment:11 Changed 7 years ago by Gesner Passos

re #8528: Update SliceEvent to apply slicing

Changeset: 350a37d557dfe86964a8bcb5c2dfd8d1549d2a7c

comment:12 Changed 7 years ago by Gesner Passos

re #8528: Use the slices to compose the name of the output

Changeset: 03ecb197b7b5de239896e9940d867cb0700f8ca7

comment:13 Changed 7 years ago by Gesner Passos

re #8528: Export the slicing support to the ISISCommandInterface

Changeset: f76ec3bc1dd6642344e276cd67952afe4403826b

comment:14 Changed 7 years ago by Gesner Passos

Refs #8528. Allow reducing multi slices from event workspaces

Changeset: 884ff7fd7d00dcc6e28b348a9dba2d2dc6a6374f

comment:15 Changed 7 years ago by Gesner Passos

Refs #8528. Avoid slicing the sample

By making the can workspaces histograms, in loading time, we ensure that they will not be sliced in any time during reduction.

Changeset: fe55d8446e08dd557fab2aa5a9ddcfaecd0a4f7d

comment:16 Changed 7 years ago by Gesner Passos

Refs #8528. Correct error related to reduction in batch

Because assignSample cleaned the slices definition, it lacked support for slices. Now, it is cleaned on loading mask.

Changeset: 3327bcc77a17a54f56d51c44dfab52b83730361b

comment:17 Changed 7 years ago by Gesner Passos

Re #8528: Ensure operation of slicing in batch and single mode.

Changeset: 6628586c0a29c83f5a0abb4929dce7dd26545b65

comment:18 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Cc peter.parker@… added
  • Resolution set to fixed

There is a systemtest as well.

comment:19 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:20 Changed 7 years ago by Peter Parker

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Running the following in the console:

from mantid.simpleapi import *

import ISISCommandInterface as i    
import SANSBatchMode as batch

BATCHFILE = FileFinder.getFullPath('sans2d_reduction_gui_batch.csv')

i.SANS2D()
i.MaskFile(MASKFILE)
i.SetEventSlices("<451")
fit_settings = batch.BatchReduce(BATCHFILE, '.nxs',saveAlgs={}, combineDet='rear')

gives the following error:

ValueError: When converting parameter "StartTime": Selected value -1 is < the lower bound (0)
  at line 11 in 'New script'

comment:21 Changed 7 years ago by Gesner Passos

  • Blocked By 8548 added

comment:22 Changed 7 years ago by Gesner Passos

  • Status changed from reopened to inprogress

comment:23 Changed 7 years ago by Gesner Passos

It seems to have lost one commit:

Refs #8528: Parse correctly -1 option SANSUtility

It translate the -1 option. Put some words to explain the code as well.

commit: 41697db0ee4014e8716f019f27bc94d80f9bb712

comment:24 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:25 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying

comment:26 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8528_slice_event'

Full changeset: 1f76e3983ef87588def592668f3b8c4ec451e758

comment:27 Changed 7 years ago by Peter Parker

Merge remote-tracking branch 'origin/feature/8528_slice_event'

Full changeset: 0d2276e51ef86cd6939e97878c2393349c601ad2

comment:28 Changed 7 years ago by Peter Parker

Problem fixed.

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9372

Note: See TracTickets for help on using tickets.