Ticket #8536 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add features to FileValidator

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: zhouw@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Add the ability to verify that a directory/file is writable to the FileValidator to allow for earlier error detection.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #8536. Added an option to check if the file is writable.

Changeset: 1022b17d38bb4f1dd7103d22fd1edc39f530703a

comment:2 Changed 7 years ago by Peter Peterson

Re #8536. Using new FileValidator functionality in FileProperty.

Changeset: b902e1a16e8d50f3ced2ddf864306a70fcd1c018

comment:3 Changed 7 years ago by Peter Peterson

Re #8536. Using absolute path in the error if possible.

Changeset: 453d6b7c0580c4a4f4c4e61d1065636b6641cec7

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is in ​feature/8536_filevalidator

To test: Try an algorithm that declares a FileAction.Save with a location that you cannot write to.

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

The failures seen on Windows & Mac show that this needs more work.

I've removed the merge to master.

comment:6 Changed 7 years ago by Peter Peterson

  • Status changed from reopened to inprogress

Re #8536. Creating a clearer error message in FileProperty.

Changeset: c1d91f54fdbf1055fc44c5ac2b88c67433ba01f0

comment:7 Changed 7 years ago by Peter Peterson

Re #8536. Don't create a temporary file.

Changeset: 157fc1f896361e40ea23fd7788e748e8919e4d0d

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Done again. Use the verification from comment:4

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:10 Changed 7 years ago by Wenduo Zhou

FileProperty can reject the invalid value of file path.

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8536_filevalidator'

Full changeset: ​8857e24b79aa7d30d6e9f29cdfceef455907dfc0

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9380

Note: See TracTickets for help on using tickets.