Error: Loading Transmission in LOQ

[Gesner Passos]

The ticket #8548 introduced an error for LOQ reduction.

It is not that it is wrong, the problem is that when acquiring transmission, LOQ acquires 3 monitors, but, the IDF says that it has only 2 monitors.

Hence, while for normal acquisition the spectrum number 3 is detector, for transmission acquisition, the spectrum number 3 is monitor.

[Gesner Passos]

re #8559: Avoiding using loading monitor for LOQ

The transmission has one monitor defined as detector (spectrum number 3) Here it will avoid loading the transmisison using loadmonitors.

Changeset: 4243800571bba53ae16b573da1718d1b6cfe6076

[Gesner Passos]

re #8559: Side effect of changes in TabulatedFunction

Ticket #2389 make the attribute Workspace case sensitive. And it causes LOQ to fail. This should go to another ticket. But, it would be difficult to split. Hence, I left it here.

Changeset: b63ed133e07133b8aeecf0bd67c457841146e622

[Gesner Passos]

re #8559: Introduction of data that will be needed for LOQReduction

Changeset: 1e74cd04016d872d3cb064dc3289edae92c3a328

[Gesner Passos]

re #8559: Ensure LoadLotsOfFiles will not complain

Changeset: 44ee9457e3267b1aa6fe4fd11ddd244c03f7af77

[Gesner Passos]

re #8559: Add the reference result

Changeset: 91023c24fdbf60293d89301f8d267cb9827227f6

[Gesner Passos]

re #8559: Add the system test

Changeset: 844c246f1bfeb1b07ca6ffb8f0d3f2b067082602

[Gesner Passos]

Tester:

I've added systemtest so to ensure that this will be covered. In fact, I found with the systemtest that there was another error introduced since #2389.

I created the reference result using an old version where the results were non to be correct. Then, I checked that it worked after the current patch.

I found this error when I was following the steps listed on this link: http://www.mantidproject.org/SANS_Data_Analysis_at_ISIS

What, right now, is exactly what the systemtest does.

If you want step by step to test it:

• open SANS ISIS
• load mask file: MaskLOQData.txt (systemtest)
• load batch file: loq_batch_mode_reduction.csv
• run 1d reduction

You might be interested in changing some settings to ensure it still works.

[Gesner Passos]

It involves systemtest, it is necessary to wait till Friday (06/12) to test it.

[Karl Palmen]

I can't find MaskLOQData.txt in systemtest. This might be because i don't know where to look, so I'm returning it to testing pool. I would have asked Gesner, if he were in.

[Peter Parker]

Merge remote-tracking branch 'origin/bugfix/8559_loq_load_trans'

Full changeset: ​48417523f5a76c4fa7aea220f2db4bcfbeb78a74

[Peter Parker]

Merge remote-tracking branch 'origin/feature/8559_full_loq_reduction'

Full changeset: ​904a3016e49b66cfb904f7e680b0497f138dc9a3

[Peter Parker]

Unfortunately, reducer.instrument.name() != 'LOQ' had to be introduced, but it has an explanatory comment to make it clear why this is the case.

Otherwise, looks good.

[Stuart Campbell]

This ticket has been transferred to github issue ​9403