Ticket #8629 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IndirectDiff] Remove warning message from OSIRISDiffractionReduction

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: trivial Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Samuel Jackson) (diff)

Reported by Franz Demmel. The following warning shows up when running OSIRISDiffractionReduction with the standard calibration file. 

AlignDetectors started (child)
2 errors (invalid Detector ID's) found when reading .cal file 'C:/opengenie/larese/osiris_041_RES10.cal'.
AlignDetectors successful, Duration 0.16 seconds

I've investigated this and it appears this is simply down to the fact that the monitors are included in the calibration file and when align detectors runs it cannot find anything with an ID matching the monitor.

The best option here would be to check if it's a monitor at the level that's appropriate and simply ignore them.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Samuel Jackson

  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress
  • Owner changed from Samuel Jackson to Dan Nixon
  • Milestone changed from Backlog to Release 3.3

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to assigned

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added check to see if a detector ID is a monitor

Refs #8629

Changeset: 40a33f9eb4d5415be457a804bae4e796fa343772

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

The main issue was with the LoadCalFile algorithm assuming that a detector ID was bad if it was not a detector, where it could be a valid ID for a monitor.

To test:

  • Run LoadCalFile with the default OSIRIS cal file (usage examples folder)
  • Notice that the message is no longer displayed
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:7 Changed 6 years ago by Dan Nixon

Fix Doxygen warning in LoadCalFile

Refs #8629

Changeset: 79f233734ea1b30bef43835216d7d192444ae59c

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8629_remove_warning_when_loadcalfile_cannot_find_monitors'

Full changeset: ​18cb0266984d8fe41ae5a0f385ce93c12123ccbf

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9473

Note: See TracTickets for help on using tickets.