Ticket #8636 (inprogress)

Opened 7 years ago

Last modified 5 years ago

An algorithm instance is created many times when bringing up an algorithm dialog

Reported by: Russell Taylor Owned by: Anyone
Priority: minor Milestone: Backlog
Component: Framework Keywords: student, core
Cc: Blocked By:
Blocking: Tester:

Description

It's created once for each property because of the call to AlgorithmProxy::createConcreteAlgorithm() in AlgorithmProxy::setPropertyValue(). It doesn't seem to cause a big problem, but surely it's not necessary.

A sample stack trace is here: 

Mantid::API::Algorithm::initialize() at Algorithm.cpp:293 0x7ffff6b23408	
Mantid::API::Algorithm::initializeFromProxy() at Algorithm.cpp:981 0x7ffff6b280f6	
Mantid::API::AlgorithmProxy::createConcreteAlg() at AlgorithmProxy.cpp:250 0x7ffff6b65f4f	
Mantid::API::AlgorithmProxy::setPropertyValue() at AlgorithmProxy.cpp:219 0x7ffff6b65c92	
MantidQt::API::AlgorithmDialog::setPropertyValue() at AlgorithmDialog.cpp:299 0x7ffff65c36f7	
MantidQt::API::AlgorithmDialog::setPropertyValues() at AlgorithmDialog.cpp:341 0x7ffff65c3b08	
MantidQt::API::AlgorithmDialog::initializeLayout() at AlgorithmDialog.cpp:88 0x7ffff65c2a04	
MantidQt::API::InterfaceManager::createDialog() at InterfaceManager.cpp:79 0x7ffff65e8442

This seems to have come in at ​https://github.com/mantidproject/mantid/commit/b5b41a9ea2638b54dbbc37612d2a7c69c5fac5b2

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Nick Draper

  • Keywords student, core added

As this is highly used code make sure your changes are reviewed by a senior developer

comment:3 Changed 6 years ago by Martyn Gigg

  • Milestone changed from Backlog to Release 3.3

comment:4 Changed 6 years ago by Harry Jeffery

  • Owner set to Harry Jeffery
  • Status changed from assigned to inprogress

comment:5 Changed 6 years ago by Harry Jeffery

  • Owner changed from Harry Jeffery to Anyone

Requires some thought, and provides little advantage. Leaving for now.

comment:6 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:7 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9480

Note: See TracTickets for help on using tickets.