Ticket #8713 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveAscii version 2 workspace ID indexing

Reported by: Keith Brown Owned by: Keith Brown
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Jose Borreguero

Description

Jose Borreguero: " The first allowed workspaceIndex should be zero, not one

You can't enter WorkspaceIndexMin=0 because 0 is not allowed. Then try to save it with WorkspaceIndexMin=1 and WorkspaceIndexMax=9. It will issue and error ("Inconsistent spectra interval") because the maximum workspace index is 8, not 9 "

I made a mistake when defining WorkspaceIndexMin, the validation needs a slight tweak

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress

Refs #8713. Fixed bounds problem

The algorithm should now accept zeros for workspaceID Max/min bounds

Changeset: d7e3965a2f2ce59ff35bff319dd3e2a3859ae7a1

comment:2 Changed 7 years ago by Keith Brown

Refs #8713. Fix unit tests due to changed bound

After changing the bounds i neglected to change the systemtest to accomodate.

Changeset: b2d4992a660b8e5baa53f99beab7a86bff2d7c64

comment:3 Changed 7 years ago by Keith Brown

Refs #8713. disable saveascii2 unit tests

disabling tests while i find out what's gone wrong

Changeset: d903899ac511e6b88449e67254da3ee79b9e83c1

comment:4 Changed 7 years ago by Keith Brown

Refs #8713. more disabling

commenting it out the cmake to porperly disable the test

Changeset: dfef6b6187e762ec81872da19d811d967d06e0a6

comment:5 Changed 7 years ago by Keith Brown

Refs #8713. Re-enable fixed tests

The tests should work now, made some improvments to path checkign while i was at it.

Changeset: e69c8757b0ab8f653acf88a9781edfadf8ff98d6

comment:6 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Peter Peterson

  • Milestone changed from Backlog to Release 3.1

Moving to the current release since testing it will put it in master.

comment:8 Changed 7 years ago by Jose Borreguero

  • Status changed from verify to verifying

comment:9 Changed 7 years ago by Jose Borreguero

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8713_SaveAscii2_Workspace_ID'

Full changeset: ​1c77c1707deaa635de3f02870771e30afa297299

comment:10 Changed 7 years ago by Jose Borreguero

Workspace index validators work as expected

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9557

Note: See TracTickets for help on using tickets.