Ticket #8717 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

Copy / Clone Component updating the pmap

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 3.1
Component: Framework Keywords: Core
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Ricardo Leal) (diff)

New copy constructor to be used with clone:

  • Clone if parametrized throws
  • Copy constructor leaves m_pmap Null

Change History

comment:1 Changed 7 years ago by Ricardo Leal

  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Ricardo Leal

  • Status changed from new to inprogress

Re #8717 working tests with clone.

Changeset: 552fa47439724cedf774b13f1b6eca9f36412535

comment:3 Changed 7 years ago by Ricardo Leal

Re #8717 Probably no copy clone is needed.

Changeset: 48666efc5ad6547a0842f27287af524f38061b98

comment:4 Changed 7 years ago by Ricardo Leal

Re #8717 parametrerized clone throws.

Changeset: ec6b13aca46da35f5af28166dc3e444443a778a0

comment:5 Changed 7 years ago by Ricardo Leal

  • Description modified (diff)

comment:6 Changed 7 years ago by Ricardo Leal

Test : testCloneConstructorParameterised() in ComponentTest.h

comment:7 Changed 7 years ago by Ricardo Leal

  • Keywords Core added
  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Ricardo Leal

Re #8717 Cleanup commented code.

Changeset: e2f37c69530e2fe48ac2a9f09049db29d92ffa65

comment:9 Changed 7 years ago by Ricardo Leal

Revert "Re #8717 Cleanup commented code."

This reverts commit e2f37c69530e2fe48ac2a9f09049db29d92ffa65.

Changeset: 60eb29ec6ad6e2bbae7c9eefa0b720034e4532e5

comment:10 Changed 7 years ago by Ricardo Leal

Re #8717 Fixed Build.

Changeset: de41ae195ed408fdcd835225d661b82a37e65cf1

comment:11 Changed 7 years ago by Ricardo Leal

Ready to be verified. See testCloneConstructorParameterised() in ComponentTest.h

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:13 Changed 7 years ago by Russell Taylor

Ricardo - Just a check before testing: do you still want/need this after discussions you had this week?

comment:14 Changed 7 years ago by Ricardo Leal

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Russel: Probably not useful any longer. I will keep the branch locally in any case.

comment:15 Changed 7 years ago by Ricardo Leal

  • Status changed from reopened to verify
  • Resolution set to invalid

comment:16 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying

comment:17 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

OK - can you delete your branch on GitHub if you have a copy?

comment:18 Changed 7 years ago by Ricardo Leal

I think so... this should work (?) 

git branch -d -r origin/feature/8717_copy_clone_pmap_and_component

comment:19 Changed 7 years ago by Russell Taylor

Quickest way is to go to ​https://github.com/mantidproject/mantid/branches and click the delete branch button!

comment:20 Changed 7 years ago by Ricardo Leal 

           /(|
          (  :
         __\  \  _____
       (____)  `|
      (____)|   |
       (____).__|
        (___)__.|_____

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9561

Note: See TracTickets for help on using tickets.