Ticket #8724 (closed: fixed)
Support BackToBackExponential in LoadFullorofResolution to instrument
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Diffraction | Keywords: | |
| Cc: | zhouw@…, anders.markvardsen@… | Blocked By: | |
| Blocking: | Tester: | Wenduo Zhou |
Description
At present whenever LoadFullprofResultion saves parameters to in instrument in a workspace, the function to which the parameters apply is assumed to be IkedaCarpenterPV.
If NPROF=9 in the fullprof .irf file, make the function be BackToBackExponential.
Attachments
Change History
comment:3 Changed 7 years ago by Karl Palmen
Preliminary rearrangement of code re #8724
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1437275fafbeec1088ce66197d0233c35adb6d22
comment:4 Changed 7 years ago by Karl Palmen
Make the changes in LoadFullprofResolution re #8724
Unit test needs adding.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f03e42e5c604a3b107124e1cff98eef2a8060780
comment:5 Changed 7 years ago by Karl Palmen
Remove Debug XML file production re #8724
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ef1c9f2790bb2d6c911fad8375240f2f84517029
comment:6 Changed 7 years ago by Karl Palmen
Work on unit test LoadFullprofResolutionTest.h re #8724
Unit test crashes DO NOT GIT CHECKBUILD
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: c045b57372c457908ea1743055131f5c806b9d2c
comment:7 Changed 7 years ago by Karl Palmen
Fix bug in unit test re #8724
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 25ad983fd684501af3a0bb399efe9802841883f9
comment:8 Changed 7 years ago by Karl Palmen
Complete the unit test re #8724
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6acf8eac2c66098b236598b90c8c7e71805ca614
comment:9 Changed 7 years ago by Karl Palmen
Improve documentation of algorithm re #8724
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f73f495c20eeee80cb88acd1ffa2eec1bf32f299
comment:10 Changed 7 years ago by Karl Palmen
Fix S parameter of LoadFullprofResolution.cpp re #8724
This change has not been built or tested.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: cc2756911073f500e6fb5e562e0b24067cb997d6
comment:11 Changed 7 years ago by Karl Palmen
Use correct figures in unit test re #8724
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 4288fbe3b0c338bdb718d6d7362aede79fa164fc
comment:12 Changed 7 years ago by Karl Palmen
To test, check that unit test test_workspace_BBX() is correct and adequate. You may also run Mantid to test this and may use the attached file for this.
Changed 7 years ago by Karl Palmen
- Attachment HRPD_ISIS_Cycle_10_2new.irf added
HRPD IRF file that may be used for testing
comment:13 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:15 Changed 7 years ago by Wenduo Zhou
- Status changed from verifying to reopened
- Resolution fixed deleted
Could you attach a reduced HRPD data file so that I can try to fit the back-to-back exponential with the profile parameter values loaded from the attached .irf file.
That will be the last thing that I need to test for this ticket.
comment:16 Changed 7 years ago by Karl Palmen
- Status changed from reopened to verify
- Resolution set to fixed
I hope the hrp55500.nxs is such a file.
comment:18 Changed 7 years ago by Wenduo Zhou
The unit test looks adequate to me.
I could load the .irf file to a data workspace and fit a back-to-back exponential peak in the fitting gui with the starting values set up automatically by MantidPlot from the loaded .irf file.
comment:19 Changed 7 years ago by Wenduo Zhou
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8724_support_back_to_back'
Full changeset: 467cbb273a95a290553150be54eb91ffcd8d1cc4
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9568
