Ticket #8736 (closed: invalid)
Change detectors IDs
| Reported by: | Ricardo Leal | Owned by: | Ricardo Leal |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | Core |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
To append the instrument with other instrument / bank the detector IDs must be updated.
Change History
comment:2 Changed 7 years ago by Ricardo Leal
- Keywords Core added
- Status changed from inprogress to verify
- Resolution set to fixed
Removed const from detId. Appended a few lines to testId().
comment:3 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
I'm not too keen on this (see comments about immutability earlier today!). Comments are unfortunately not a reliable way to enforce behavior. It wouldn't surprise me to see this new method exposed to python by someone at some point in the future and then anyone could mess with it.
Could the goal be achieved by creating an entirely new Detector (and perhaps an entirely new instrument) with the correct ID. Two concerns come to mind: detector IDs are stored in the ISpectrum to map the data to the correct pixel. More importantly, instruments are stored and re-used in the Instrument Data Service and so modifying it behind the scenes could lead to surprises.
Either way the implementation of the method, however simple, should not be in the header file (even if someone else has done that).
comment:4 Changed 7 years ago by Ricardo Leal
There's better ways of doing this. Close invalid ticket.
comment:5 Changed 7 years ago by Ricardo Leal
- Status changed from reopened to verify
- Resolution set to invalid
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
Re #8736 DetectorIds are now changeable.
Changeset: ce2b1659dcb5e43b281148cc67707ce33ca990c4