Ticket #8777 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

FuryFit Function default values.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Arturs Bekasovs

Description (last modified by Samuel Jackson) (diff)

FuryFit does not infer default start parameters from the plotted workspace. Running with some fit parameters set to the default can cause Mantid to hang.

For example, start parameters for 1 stretched exponential could be:

Intensity=1-LinearBackground; Beta=1.0; Tau is calculated from data using Tau=-x/log(y)

Intensity and background must sum to 1.

Consult Spencer for further information on start parameters for the other functions.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Description modified (diff)

comment:2 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.2

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #8777 Update with a better value for tau.

Changeset: 40aae340e2b0d569cf455ffbcacdd95e88ad4868

comment:5 Changed 7 years ago by Samuel Jackson

Refs #8777 Plot guess after switching function type.

Changeset: 40b6dc75356ecda06de7596f83f53a15537e7260

comment:6 Changed 7 years ago by Samuel Jackson

Refs #8777 Constrain range to be between 0 and 1

Changeset: 2da2cbff9d72b41ec0ad62f1ceb8c7c4c7bb2c90

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

FuryFit should now have default parameters as suggested in the ticket description. The intensity and background should now always sum to 1. Check that this is now the case for all fit functions.

comment:8 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verify to verifying
  • Tester set to Arturs Bekasovs

comment:9 Changed 7 years ago by Arturs Bekasovs

All code changes are reasonable.

Intensity and background have never summed up to more than 1 while I was playing with it, and the code suggests they couldn't possible do so.

Default parameters seem all right (Mantid never hang) and are used in all the fit functions.

The problem with spectra range not being checked has been discovered as discussed with Sam.

comment:10 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8777_furyfit_default_values'

Full changeset: ​3bb7cfab10c771772210b5f3ca92e3364ab41b6b

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9621

Note: See TracTickets for help on using tickets.