Ticket #8823 (closed: fixed)
icat instrument full name
| Reported by: | Jay Rainey | Owned by: | Jay Rainey |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.2 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Parker |
Description
Sam mentioned that it would be more user-friendly to have the full name of instruments displayed in the instrument drop-down instead of their short name.
Change History
comment:2 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
This is a simple change to display the full name of the instrument in the instrument list combo-box.
To verify
- Log into the catalog and open the "Search" interface.
- Observe that the instrument names are full names, for example, OSI becomes OSIRIS and POL becomes POLARIS etc.
comment:3 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:4 Changed 7 years ago by Peter Parker
- Status changed from verifying to reopened
- Resolution fixed deleted
I like this idea as it makes the names more consistent with how they appear elsewhere in Mantid. Unfortunately, we've introduced a bug.
In Mantid 3.1, I have access to "CSP" data. In a built version of this ticket's branch I get no results when I select the equivalent option, "CRISP".
Note that I get results for both versions when I select an unchanged instrument, for example "EVS".
Is this just a case of making sure we're using instrument.fullName everywhere else, instead of just instrument.name?
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from reopened to inprogress
Use fullName in search query. Refs #8823.
Changeset: 1f86385a2cd101989ccb90165eb7f894192b4efb
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
Is this just a case of making sure we're using instrument.fullName everywhere else, instead of just instrument.name?
Yes, I was using name for the search of the instrument the user has selected, which was wrong. (I tested it on instruments such as WISH etc, which did not change with the update, doh!)
To test this ticket, see comment:2.
comment:8 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8823_icat_full_inst_name'
Full changeset: cea248f9ad4f45b4daa6494fed2d045f8703694c
comment:9 Changed 7 years ago by Peter Parker
Tested with CRISP ("CSP" for short) and WISH (shortened name == full name), and both returned the same set of files in searches on a locally built branch and 3.1. Also grepped for any more instances of ".name" in the ICat folder and found none.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9667
Use full name instead of short name. Refs #8823.
Changeset: 6ec001793edf4fa5f9a862922e2e4dd3bad09543