Ticket #8983 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove WorkspaceIterator code & usage

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.2
Component: Framework Keywords: Maintenance
Cc: Blocked By: #8784
Blocking: Tester: Peter Peterson

Description

Currently only two algorithms use the workspace iterators:

  • SaveRKH
  • Qxy

The majority of the usage is in the tests. Since we have found that the performance of them is not good enough then we should remove them to stop them being used in the future and remove code we no longer have to maintain.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Blocked By 8784 added

comment:2 Changed 7 years ago by Martyn Gigg

Checkpoint workspace iterator removal.

Refs #8983

Changeset: 9cecd2c99618d5366e82305edd9a9576416798f3

comment:3 Changed 7 years ago by Martyn Gigg

Remove WorkspaceIterator from SaveRKH.

Refs #8983

Changeset: ce04425e90416864444c23850bd8626c74364e04

comment:4 Changed 7 years ago by Martyn Gigg

Remove workspace iterators from UserAlgorithms

Refs #8983

Changeset: c9d93ec2c6e16aca94c8412ed9b9ab726bda06e4

comment:5 Changed 7 years ago by Martyn Gigg

Remove WorkspaceIterator code

Refs #8983

Changeset: 03eb920f2286e355c3b1ad9f908123fef3fa9b0c

comment:6 Changed 7 years ago by Martyn Gigg

Remove WorkspaceIteratorCodeTest

Refs #8983

Changeset: 8b4d456e6df47b8c48e3c07e5b91974a4edfc6d6

comment:7 Changed 7 years ago by Martyn Gigg

Remove WorkspaceIterator usage in tests.

Refs #8983

Changeset: 41d43a04e54ee3f0eb80501bf35ea75ea2a3c027

comment:8 Changed 7 years ago by Martyn Gigg

Fix broken Scale*Tests

Refs #8983

Changeset: f4307dd8823afe916a0544fa5c90516a79a38f99

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from assigned to verify
  • Resolution set to fixed

Branch: task/8983_rm_workspaceitr

Tester: This was a task to remove our very old & inefficient way of iterating over a workspace and all tests should be still be passing and there are no actual feature changes/bugfixes.

comment:11 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:12 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Merge remote branch 'origin/task/8983_rm_workspaceitr'

Full changeset: d52367638bd53dc3ff8c738c6ee4b41017d45bc1

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9826

Note: See TracTickets for help on using tickets.