Ticket #9042 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Theta value not getting populated.

Reported by: Owen Arnold Owned by: Keith Brown
Priority: major Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Owen Arnold) (diff)

In the Reflgui -

The theta value in the GUI doesn't get populated if left blank.

Investigate why, this may require looking at the original version of the GUI to figure out what it was doing.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Description modified (diff)

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from assigned to inprogress

Refs #9042 Theta is now retrieved or calculated if not supplied

Quick had a problem where it required theta as the way it was retrieving it didn't work.

In the case where it doesn't have theta it'll first try and retrieve theta from the sample logs, and failing that, calculate it manually

The function now uses the _sample_ws loaded earlier to retrieve from. The problem stemmed from the way we've been changing how parameters to quick are provided, as run_ws was an old variable that had been forgotten about in the midst of these changes.

Changeset: d3e75a0074f8286c2071a191e56266551557e62e

comment:4 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:6 Changed 7 years ago by Keith Brown

To Tester:

Follow the instructions here, deleting values in the angle column to make sure it'll work them out if not supplied: http://www.mantidproject.org/ISIS_Reflectometry_Examples

Last edited 7 years ago by Keith Brown (previous) (diff)

comment:7 Changed 7 years ago by Nick Draper

Code review looks good, simple changes, mainly trying to get the value from the sample logs before doing the same calculation as previously is no value is found.

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9042_refl_gui_populate_theta'

Full changeset: cef16616e07c0a6f44ee3468f81d90be4e22a859

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9885

Note: See TracTickets for help on using tickets.