Ticket #9051 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

"Use the same window" option for MuonAnalysis

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.2
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

On the settings tab, add another option, which when enabled would make the interface use the same (effectively the previous) window for plotting. This should solve the problem of the new graph appearing in an unexpected place all the time.

However, sometimes it is useful to keep the previous graph as well. So the trial solution agreed on by the scientists is to copy the old graph to the new window.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from assigned to inprogress

Refs #9051. Widgets for the new option

Changeset: 0eb5aef3bbe6f55d2ea726bbcace4e46b0a3b456

comment:3 Changed 7 years ago by Arturs Bekasovs

Refs #9051. Functionality for retrieving selected policy

Changeset: 4b41215fadde0aa13829776f675c20a56c320bf5

comment:4 Changed 7 years ago by Arturs Bekasovs

Refs #9051. Update plotting code to use the new option

Changeset: 8df6af6b2e960ab0e0f72b774b98fd75a41aa44d

comment:5 Changed 7 years ago by Arturs Bekasovs

Refs #9051. Move plot hiding to more appropriate place

And disable it when using previous window

Changeset: f3ff6025d95b22231f0a7657b30b00e655ef7774

comment:6 Changed 7 years ago by Arturs Bekasovs

Refs #9051. Move the option retrieval stuff to settings tab code

Plus make it's value auto-saveable

Changeset: 35a4a06afaa05b51e40417596d5ba58f953c72ef

comment:7 Changed 7 years ago by Arturs Bekasovs

Tester:

I've decided not to implement "Copy previous plot to new window before replacing it" functionality in this ticket. This is because it is quite difficult thing to do, as it turns out: lots of stuff should be fixed before I can do that. To save my self from lots of tedious work, I will ask scientists to check this version out first. Though if they will insist that they want to keep the old graphs, I will surely implement it anyhow, but in a separate ticket.

Additionally, it simplifies a life of this ticket's tester a lot. :-)

Please check the following:

  1. The new option was indeed added and works as expected.
  2. Switching between new plot policies on-the-go works as expected.
  3. The option selection is saved between the interface runs, but defaults to "New window".
  4. "Hide previous plots" option works when using "New window".

comment:8 Changed 7 years ago by Arturs Bekasovs

Refs #9051. Merge branch 'feature/9051_muon_use_same_window' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/MuonAnalysisOptionTab.h Code/Mantid/MantidQt/CustomInterfaces/src/MuonAnalysisOptionTab.cpp

Changeset: d9007335ff48093dd90e49dd7c03771ff7b60320

comment:9 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:11 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9051_muon_use_same_window'

Full changeset: 243da98e0bf06a5eb20c6a3e0dcf20c34337f7ee

comment:12 Changed 7 years ago by Samuel Jackson

Option appears to work as expected and the code looks good.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9894

Note: See TracTickets for help on using tickets.