Allow use of parameters to override geometric values in ConvertUnits

[Stuart Campbell]

In the same way that if Efixed is specified on the instrument, we have had a request to allow the other parameters that are used in ConvertUnits(). I propose the names of the parameters should be:

• L1
• L2
• TwoTheta
• Efixed
• Emode

Ensure ConvertUnits documentation is updated.

[Russell Taylor]

For info: It's been pointed out that there is the EditInstrumentGeometry algorithm, though I think I still prefer the sugested way as it allows for defining it at runtime or in a parameter file.

[Stuart Campbell]

Added L1,L2 and TwoTheta pars to override geometry

Also added getters/setters similar to getEFixed() Exposed to Python

refs #9063

Changeset: 7a3e9f9fb4a0be251654bc06d8eaff7428476bfd

[Stuart Campbell]

Added some debug statements. refs #9063

Changeset: 34bfb3740b1f3c36b2a82e94f41ff39c8d79c5dc

[Stuart Campbell]

Added unit test to check for parameters.

refs #9063

Changeset: f020ac1139c6d972c27ad5d729c48d9281d81585

[Stuart Campbell]

Updated expected results to be correct number!

refs #9063

Changeset: 5bb1bc91840b22815d88a12dcf03ebe8e7de0af9

[Russell Taylor]

Unfortunately, the performance tests are showing this to be very expensive. We're going to have to improve performance or think of a different way of doing it.

[Stuart Campbell]

Disable override parameters unit test. refs #9063

I have done this to try and measure the effect on performance (of ConvertUnits) for having the option of overriding parameters be there but not using it.

Changeset: 334bb07a7e7d5c9a966da8a129a738b24ab24132

[Stuart Campbell]

This method of doing it is too slow.

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​9906