Ticket #9066 (closed: wontfix)

Opened 7 years ago

Last modified 5 years ago

Improve FindPeaks' performance by filtering out false fit

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: petersonpf@…, lynchve@… Blocked By:
Blocking: Tester: Russell Taylor

Description

In the cases that there is no peak or peak's height and width are close to noises nearby, "FindPeaks" tends to fit the whole region as a super wide peak. Thus it gives out a wrong result while the goodness of fit, such as chi-square, is good.

Implement some algorithm such that these situations can be handled.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Wenduo Zhou

  • Blocking 7789 removed

comment:3 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to wontfix

The issue has been solved partially by the combination of effort in ticket #7789 to refactor FindPeaks. And another decision was made to leave the caller of FindPeaks, for example GetDetOffsetsMultiPeaks to judge whether FindPeaks returns a correct result.

comment:4 Changed 6 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 6 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9909

Note: See TracTickets for help on using tickets.