Refl_gui Improvements - Patch Release Bugfixes

[Keith Brown]

In #9041 I fixed a few bugs that were present for far too long and shouldn't have got to master. They need to be added to a separate ticket too so that they can be added to the patch.

• Coadding workspaces with : or , doesn't work
• File->Close Refl Gui should actually close it, as presently it loads help.
• Clearing, reloading or opening a table should do a modified check and offer to save
• Clearing the table shouldn't set the modified flag

[Keith Brown]

Refs #9077 Modified checks, File-> Close and Coadd

The following has been fixed:

• File->Close Refl Gui now actually closes it, as until now it had loaded help.
• Clearing, reloading or opening a table will now do a modifed check and offer to save
• Clearing the table no longer sets the mdoified flag
• Coadding workspaces now works as intended

Changeset: 57030f81f02b4a370689c104cc655f89a5b2c4c3

[Keith Brown]

Works as intended

To Tester:

DO NOT PUSH THIS TO MASTER!

Make sure that file-> Close refl Gui works as labelled

Open a table, modify it a bit then go file->reload table. You should be presented with a yes/No question of "do you want to lose your changes"

Open a table, modify it a bit then hit Clear All. You should be presented with a save/discard/cancel question of "do you want to save your changes"

Open a table, modify it a bit then go File->Open Table and choose a new table. You should be presented with a save/discard/cancel question of "do you want to save your changes"

Open a table, clear the table then open a new file. No prompts to save should appear

Open a table and add a comma and another run number to one of the run(s) column and process it. It should complete without error. Do the same with a colon.

DO NOT PUSH THIS TO MASTER!

[Nick Draper]

Moved to patch release 3.1.1

[Owen Arnold]

There is unnecessary duplicate code here. Please refactor to a common function.

[Keith Brown]

Refs #9077 Refactored save check code

Some of the save check code has now been refeactored into a separate method. One check messages couldn't be refactored as it's asking a different question.

Changeset: 03c7ab5d7943f6fb0096d4912bb0355427687add

[Owen Arnold]

Please re-check the reload functionality. It doesn't cause a prompt message when the table is reloaded.

[Keith Brown]

Reload functionality does work, I've seen it work on both windows and Mac.

[Owen Arnold]

Passed, but am not merging to master.

[Keith Brown]

Refs #9077 Modified checks, File-> Close and Coadd

The following has been fixed:

• File->Close Refl Gui now actually closes it, as until now it had loaded help.
• Clearing, reloading or opening a table will now do a modifed check and offer to save
• Clearing the table no longer sets the mdoified flag
• Coadding workspaces now works as intended

Changeset: b1d38b56675c081626724ddf5af2eaf5e7824bbd

[Keith Brown]

Refs #9077 Refactored save check code

Some of the save check code has now been refeactored into a separate method. One check messages couldn't be refactored as it's asking a different question.

Changeset: b234076beac3ba4fc463a1cb08ac43ab8e0475c5

[Russell Taylor]

The above commits are because I rebased the topic branch onto the commit in master corresponding to the 3.1 release.

[Stuart Campbell]

This ticket has been transferred to github issue ​9920