Ticket #9147 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add filtering to PDFFourierTransform

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Add an option to PDFFourierTransform to apply a Lorch window filter: multiply the input by sin(q * pi/qmax) / (q * pi/qmax)

Attachments

ws.nxs​ (60.4 KB) - added by Roman Tolchenov 7 years ago.
Filter.pdf​ (11.1 KB) - added by Roman Tolchenov 7 years ago.
NoFilter.pdf​ (11.6 KB) - added by Roman Tolchenov 7 years ago.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #9147. Added Lorch function filter to PDFFourierTransform

Changeset: 1bb01e4d75925186b21d8f41012ef18c42d39b42

comment:3 Changed 7 years ago by Roman Tolchenov

Re #9147. Added a short comment

Changeset: d1c65011fb5f036361eb87842896603d7b0b8c14

comment:4 Changed 7 years ago by Roman Tolchenov

Re #9147. Updated the WIKI page

Changeset: 3fe3be9e4247888490779092758037a3470922bc

Changed 7 years ago by Roman Tolchenov

Changed 7 years ago by Roman Tolchenov

Changed 7 years ago by Roman Tolchenov

comment:5 Changed 7 years ago by Martyn Gigg

There is a compiler warning about an ​unused variable. Could that be addressed, please?

comment:6 Changed 7 years ago by Roman Tolchenov

Re #9147. Fix compiler warning

Changeset: 5f0037f9ad4561b67905e56c04cb5da26698a40b

comment:7 Changed 7 years ago by Roman Tolchenov

To tester

  1. Load attached ws.nxs. It contains a single spectrum with all values = 1.
  2. Run PDFFourierTransform on it. Set InputSofQType to "S(Q)-1", Qmax to 20 and PDFType to "G(r)".
  3. If Filter property is set the result should look like the picture in Filter.pdf
  4. If Filter property is unset the result should look like the picture in NoFilter.pdf

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:10 Changed 7 years ago by Wenduo Zhou

It works as purpose. So it is closed.

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9147_pdffouriertransform_filtering'

Full changeset: ​b1c50c2f59c8a683551a22db16fc264e0bac9655

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9990

Note: See TracTickets for help on using tickets.