Ticket #9149 (inprogress)

Opened 7 years ago

Last modified 5 years ago

Use PropertyWidgets in Custom Dialogs

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Backlog
Component: GUI Keywords:
Cc: Blocked By: #2480
Blocking: Tester:

Description (last modified by Peter Parker) (diff)

The dynamically-generated algorithm dialogs use PropertyWidget objects. The customised algorithm dialogs (and perhaps others) should be made to use them too. This will make things more consistent, both visually and within the code, it will avoid code duplication, and will also allow make the #2480 functionality more widespread.

No work required:

  • SmoothNeighbours - (Already uses PropertyWidgets fully)
  • LoadDAE - (Deleted algorithm)
  • LOQScriptInput - (Deleted algorithm)

Work required:

  • CatalogPublish
  • ConvertTableToMatrixWorkspace
  • CreateSampleShape
  • Fit
  • LoadAscii
  • Load
  • LoadInstrument
  • LoadRaw
  • PlotAsymmetryByLogValue
  • BinMD - (SlicingAlgorithmDialog)
  • SliceMD - (SlicingAlgorithmDialog)
  • StartLiveData

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Parker

  • Milestone changed from Backlog to Release 3.2

comment:3 Changed 6 years ago by Peter Parker

  • Description modified (diff)

comment:4 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Backlog

Moved to Backlog at the code freeze of release 3.2

comment:5 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9149 - Remove CustomDialog for CatalogPublish algorithm.

Instead use IPropertySetting objects to handle property complexities.

Eagle-eyed code reviewers will note that these changes don't work very well with composite catalogs, but neither did the custom algorithm dialog in its previous form. This will need to be revisited when composite catalogs are finished. In particular, what should be the allowed values of the InvestigationNumber property given multiple session IDs? How should the allowed values (as well as the default value) of the SessionID property change as well?

Also, for now, "FileName" and "InputWorkspace" are back to being on two separate rows in the dialog.

Changeset: 1ea0c96794db10400eda8d5285dafdb5f8764171

comment:6 Changed 6 years ago by Peter Parker

Refs #9149 - WIP. Needs rebasing.

Changeset: c0903658d992371996beafa4f260408c2db28cb7

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9992

Note: See TracTickets for help on using tickets.