Ticket #9176 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix SystemTests.CodeConventions.Algorithms

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: blocker Milestone: Release 3.2
Component: Framework Keywords:
Cc: Alex.Buts@… Blocked By:
Blocking: Tester: Arturs Bekasovs

Description

It is broken on develop right now because of a new version of ConvertToMDHelper. The error message is: 

FrameworkManager-[Notice] Welcome to Mantid version 3.1.20140312.1552 - Manipulation and Analysis Toolkit for Instrument Data
FrameworkManager-[Notice] Please cite Mantid in your publications using: http://dx.doi.org/10.5286/Software/Mantid
ConvertToMDHelper(v2) property (dEAnalysisMode) violates conventions

Since the previous version was grandfathered in with exactly this parameter, add this one to the exception list.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Peter Peterson

  • Status changed from assigned to inprogress

Re #9176. Added to ConvertToMDHelper v2 to the list.

Changeset: 2775a54aae2336a46f452433be7f46abc6932a5c

comment:3 Changed 7 years ago by Peter Peterson

Merge branch 'bugfix/9176_code_conventions' into develop

Conflicts:

SystemTests/AnalysisTests/CodeConventions.py

Re #9176

Changeset: 92a467cdd90b32f2e60b3ad2edd9c0054b1c4003

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​bugfix/9176_code_conventions.

To test: See that the system tests run on develop.

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verify to verifying
  • Tester set to Arturs Bekasovs

comment:6 Changed 7 years ago by Arturs Bekasovs

Simple and reasonable change. CodeConventions appears to be passing on all the develop systems test builds.

comment:7 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9176_code_conventions'

Full changeset: ​1838462943f06302890b6716d66c9ee1d96ece4e

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10019

Note: See TracTickets for help on using tickets.