Ticket #9267 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix Visual Studio compiler warnings

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

Several compiler warnings have made it onto master at some point.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #9267. Remove unused exception variables.

Changeset: eec1e95500a8a4991c76c2b61b48b1dcad515895

comment:3 Changed 7 years ago by Russell Taylor

Re #9267. Attempt to clear warning by matching type.

Changeset: 260bb7ee57326231f60042ca0a67490c0e004f82

comment:4 Changed 7 years ago by Russell Taylor

Re #9267. Another place where we need to get the type right.

Changeset: 01fa20450de7743a8fa3c4f21bb73fab677a2778

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

The develop clean build on Windows is back to zero warnings: ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_win7_develop/

comment:6 Changed 6 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:7 Changed 6 years ago by Jay Rainey

  • Status changed from verifying to closed

There are no longer any warnings on the ​Windows develop build. Closing.

Last edited 6 years ago by Jay Rainey (previous) (diff)

comment:8 Changed 6 years ago by Jay Rainey

Merge remote-tracking branch 'origin/bugfix/9267_msvc_compiler_warnings'

  • origin/bugfix/9267_msvc_compiler_warnings: Re #9267. Another place where we need to get the type right. Re #9267. Attempt to clear warning by matching type. Re #9267. Remove unused exception variables.

Changeset: d32265fda0b00b43adb8af0be61b0e06df5caead

comment:9 Changed 6 years ago by Jay Rainey

Merge remote-tracking branch 'origin/bugfix/9267_msvc_compiler_warnings'

  • origin/bugfix/9267_msvc_compiler_warnings: Re #9267. Another place where we need to get the type right. Re #9267. Attempt to clear warning by matching type. Re #9267. Remove unused exception variables.

Full changeset: ​d32265fda0b00b43adb8af0be61b0e06df5caead

comment:10 Changed 6 years ago by Owen Arnold

refs #9267. Fix merge conflict.

Merge branch 'feature/9257_ccl_performance_cppcheck_temp' into feature/9257_ccl_performance

Conflicts:

Code/Mantid/Framework/Crystal/src/ConnectedComponentLabeling.cpp

Changeset: 669233b77d16361031da3f586686443d9db4357f

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10110

Note: See TracTickets for help on using tickets.