Ticket #9344 (closed: wontfix)

Opened 6 years ago

Last modified 5 years ago

Indirect: Fix PEP8 warnings and add docstrings

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: minor Milestone: Release 3.3
Component: Indirect Inelastic Keywords: Maintenance
Cc: Blocked By: #9964
Blocking: Tester: Peter Peterson

Description (last modified by Samuel Jackson) (diff)

This is a low priority maintenance ticket. The indirect inelastic python code has many PEP8 warnings and most of the functions do not have docstrings. Files that need to be given some TLC are:

  • IndirectDataAnalysis
  • IndirectBayes
  • IndirectJumpFit
  • IndirectAbsCor
  • IndirectCommon
  • IndirectImport

A lot of this is based on Spencer's code, so talk to him if necessary for what each routine does, or refer to the MODES manual.

Change History

comment:1 Changed 6 years ago by Samuel Jackson

  • Keywords Maintenance added
  • Milestone changed from Backlog to Release 3.3

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Samuel Jackson

  • Description modified (diff)

comment:4 Changed 6 years ago by Dan Nixon

  • Owner changed from Samuel Jackson to Dan Nixon

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Fixed many warnings in Import and Common

Refs #9344

Changeset: 749102efe5830e31601d363a5be164ba2c32a92f

comment:6 Changed 6 years ago by Dan Nixon

Refactoring in IndirectAbsCor

Refs #9344

Changeset: 08fb6ae608c6681c49709b8c3ade266dd1c7e02d

comment:7 Changed 6 years ago by Dan Nixon

Resolved unit test issues

Refs #9344

Changeset: 52e1b67b6ec833b3907b1c62d9424ed53847b774

comment:8 Changed 6 years ago by Dan Nixon

IndirectDataAnalysis refactoring

Refs #9344

Changeset: d498250fca8c42284530060d6b3f27ec914559a6

comment:9 Changed 6 years ago by Dan Nixon

More general refactoring

Refs #9344

Changeset: 4aa47109518d9ad9bacd4150357d83d134f1cfdf

comment:10 Changed 6 years ago by Dan Nixon

Fix failing system tests

Refs #9344

Changeset: 0df8c857511aeb71574d921f7dad130e795919df

comment:11 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_python_refactoring' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Refs #9344

Changeset: 0e215587fd4997084f6aceb30bc66240e4369e2c

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_python_refactoring' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Refs #9344

Changeset: 1ef59414a816e3b63e44afec95a24787db3ef2c5

comment:13 Changed 6 years ago by Dan Nixon

Merge branch 'feature/9964_apply_correction_bug' into bugfix/9344_indirect_python_refactoring

Conflicts:

Code/Mantid/scripts/CMakeLists.txt

Refs #9344

Changeset: 9262cdbf1869757f3c7361d09c791b8b16a7599c

comment:14 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_python_refactoring' into develop

Conflicts:

Code/Mantid/scripts/CMakeLists.txt

Refs #9344

Changeset: df745f1d4045788a8d09ea8e7a877476f23e2fca

comment:15 Changed 6 years ago by Dan Nixon

  • Blocked By 9964 added

comment:16 Changed 6 years ago by Martyn Gigg

I think changes in commit made by comment 7, ​https://github.com/mantidproject/mantid/commit/52e1b67b6ec833b3907b1c62d9424ed53847b774, have broken the system tests on Windows. This is the build from Friday morning: ​http://builds.mantidproject.org/view/Develop%20Builds/job/develop_systemtests_all/label=win7/133/

comment:17 Changed 6 years ago by Dan Nixon

Refactoring IndirectAbsCor.py

Refs #9344

Changeset: bbe8ad916cc8c3fb55c8d3d079905fec100602b1

comment:18 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_pep8_python_refactor' into develop

Should fix failing system tests

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectAbsCor.py

Refs #9344

Changeset: 0c2d6982069e0803fa630479568b9912246a0152

comment:19 Changed 6 years ago by Dan Nixon

Modify indirect system tests to reflect refactoring

Refs #9344

Changeset: 391115b7f33a538c24f7f213582a939d7d829a67

comment:20 Changed 6 years ago by Dan Nixon

Fixed many warnings in Import and Common

Refs #9344

Changeset: 749102efe5830e31601d363a5be164ba2c32a92f

comment:21 Changed 6 years ago by Dan Nixon

Refactoring in IndirectAbsCor

Refs #9344

Changeset: 08fb6ae608c6681c49709b8c3ade266dd1c7e02d

comment:22 Changed 6 years ago by Dan Nixon

Resolved unit test issues

Refs #9344

Changeset: 52e1b67b6ec833b3907b1c62d9424ed53847b774

comment:23 Changed 6 years ago by Dan Nixon

IndirectDataAnalysis refactoring

Refs #9344

Changeset: d498250fca8c42284530060d6b3f27ec914559a6

comment:24 Changed 6 years ago by Dan Nixon

More general refactoring

Refs #9344

Changeset: 4aa47109518d9ad9bacd4150357d83d134f1cfdf

comment:25 Changed 6 years ago by Dan Nixon

Fix failing system tests

Refs #9344

Changeset: 0df8c857511aeb71574d921f7dad130e795919df

comment:26 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_python_refactoring' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Refs #9344

Changeset: 0e215587fd4997084f6aceb30bc66240e4369e2c

comment:27 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_python_refactoring' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Refs #9344

Changeset: 1ef59414a816e3b63e44afec95a24787db3ef2c5

comment:28 Changed 6 years ago by Dan Nixon

Merge branch 'feature/9964_apply_correction_bug' into bugfix/9344_indirect_python_refactoring

Conflicts:

Code/Mantid/scripts/CMakeLists.txt

Refs #9344

Changeset: 9262cdbf1869757f3c7361d09c791b8b16a7599c

comment:29 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_python_refactoring' into develop

Conflicts:

Code/Mantid/scripts/CMakeLists.txt

Refs #9344

Changeset: df745f1d4045788a8d09ea8e7a877476f23e2fca

comment:30 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/9344_indirect_pep8_python_refactor' into develop

Should fix failing system tests

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectAbsCor.py

Refs #9344

Changeset: 0c2d6982069e0803fa630479568b9912246a0152

comment:31 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to wontfix

There have been merge conflicts with this ticket and a lot of the code has been refactored in other tickets.

comment:32 Changed 6 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:33 Changed 6 years ago by Peter Peterson

  • Status changed from verifying to closed

I agree that Dan has given up.

comment:34 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10187

Note: See TracTickets for help on using tickets.