Context Navigation

Ticket #9380 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Public Static LoadfullprofResolution code to put parameters into workspace instrument

Reported by:	Karl Palmen	Owned by:	Raquel Alvarez Banos
Priority:	major	Milestone:	Release 3.3
Component:	Framework	Keywords:
Cc:	zhouw@…, anders.markvardsen@…	Blocked By:
Blocking:	#9261	Tester:	Federico M Pouzols

Description

This ticket is to make the code in LoadFullprofResolution that reads the OutputTableWorkspace and puts the parameters into the instrument of the OutputWorkspace public (as static function(s)) so that it can be used by LoadGSASInstrumentFile to perform the same function.

Change History

comment:1 Changed 6 years ago by Karl Palmen

Cc zhouw@…, anders.markvardsen@… added

comment:2 Changed 6 years ago by Karl Palmen

Owner set to Karl Palmen
Status changed from new to assigned

comment:3 Changed 6 years ago by Karl Palmen

Milestone changed from Release 3.2 to Release 3.3

comment:4 Changed 6 years ago by Anders Markvardsen

Owner changed from Karl Palmen to Raquel Alvarez Banos

comment:5 Changed 6 years ago by Raquel Alvarez Banos

Status changed from assigned to inprogress

Public static LoadFullprofResolution code Re #9380

Changeset: 8933185d29ae609dd416940c31b5e19e4eb17276

comment:6 Changed 6 years ago by Raquel Alvarez Banos

Revert "Public static LoadFullprofResolution code Re #9380"

This reverts commit 8933185d29ae609dd416940c31b5e19e4eb17276.

Changeset: 744696c9f095cb9161dbfda74bc221846d255433

comment:7 Changed 6 years ago by Raquel Alvarez Banos

Revert "Revert "Public static LoadFullprofResolution code Re #9380""

This reverts commit 744696c9f095cb9161dbfda74bc221846d255433.

Changeset: 9f2b2de193fdf91fe0e3c77777010773a28f67f3

comment:8 Changed 6 years ago by Raquel Alvarez Banos

Revert "Revert "Revert "Public static LoadFullprofResolution code Re #9380"""

This reverts commit 9f2b2de193fdf91fe0e3c77777010773a28f67f3.

Changeset: 0fc371344a5161f449201d8687865e3297ac76c5

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Public static LoadFullprofResolution code Refs #9380

Changeset: 1cc0ef4955d61b783f94fb1b63d9b556dd459607

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Status changed from inprogress to verify
Resolution set to fixed

To test:

check the changes in LoadFullprofResolution.h and LoadFullprofResolution.cpp
check that Mantid works when executing LoadFullprofResolution algorithm

comment:11 Changed 6 years ago by Wenduo Zhou

Status changed from verify to verifying
Tester set to Wenduo Zhou

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Hi Wenduo, please, can you test this so I can start working on ticket #9261. Thanks

comment:13 Changed 6 years ago by Wenduo Zhou

It works. Ticket is passed.

comment:14 Changed 6 years ago by Raquel Alvarez Banos

Public static LoadFullprofResolution code Re #9380

Changeset: e4558ea6ab9740757c30d2b57f106d0b6a7b69e2

comment:15 Changed 6 years ago by Raquel Alvarez Banos

Thanks!

comment:16 Changed 6 years ago by Raquel Alvarez Banos

Re #9380 Fixing doxygen_develop warning

Changeset: de1725e789ba0c7f49d904fd1cf4bbb40b73c667

comment:17 Changed 6 years ago by Raquel Alvarez Banos

Tester Wenduo Zhou deleted

comment:18 Changed 6 years ago by Federico M Pouzols

Status changed from verifying to verify

comment:19 Changed 6 years ago by Federico M Pouzols

Status changed from verify to verifying
Tester set to Federico M Pouzols

comment:20 Changed 6 years ago by Federico M Pouzols

This looks all fine, it does what the ticket requests, compiles and passes the tests. Several of the methods of LoadFull... have been made static and several changes have been made into the class implementation to support that. I think there's no issue, except for the following detail:

Could you confirm if it is necessary to have m_rowNumbers as a public member? It looks to me as if you were exposing too much. I'd suggest making it 'private'. If other parts of the code require additional functionality I'd suggest providing additional methods in this class, rather than making m_rowNumbers (and other class details) public.

If you agree, we can quickly re-open the ticket so you can do this minimal change and then pass it for once.

A minor fixes was done since the last test and that one also looks fine.

comment:21 Changed 6 years ago by Raquel Alvarez Banos

Re #9380 LoadFullprofResolution m_rowNumber private

Changeset: 59ab8ff90c73ce172814e7e2a67c1c0cbef54ec2

comment:22 Changed 6 years ago by Raquel Alvarez Banos

Status changed from verifying to closed

Merge branch 'feature/9380_public_static_LoadfullprofResolution' of c:/Users/dsl37522/StagingMantid into feature/9380_public_static_LoadfullprofResolution

Full changeset: f5cd70e55e9f3d06210f14b1d48551dd958d2e6d