Clear warnings from gcc4.8/numpy1.7 build

[Martyn Gigg]

Required for supporting Fedora 20 & Ubuntu 14.04.

[Martyn Gigg]

Clear warnings from deprecated functionality in numpy 1.7

Refs #9421

Changeset: e6f48598fb9827f2e747885b538c07ab66058927

[Martyn Gigg]

Clear gcc 4.8 warning about non-trivial move assignment operator

C++11 dictates that move assignment operators will only be auto-generated when a set of circumstances is met. One of these is the lack of a user-defined destructor. Add virtual destructors to the Fit hierarchy avoids the compiler generating trivial move-assignment ops and avoids the warning in virtually inheriting subclasses, e.g Python IPeakFunctionAdapter.cpp. Refs #9421

Changeset: aab4b08a3efc4227833c1994239b6ea827568c63

[Martyn Gigg]

Suppress gcc 4.8 warnings on gtest 1.7 code.

Refs #9421

Changeset: 0c9220995ec718d9d171641280fa830e1c5d5be9

[Martyn Gigg]

Fix gcc 4.8 warnings in ICat.

Refs #9421

Changeset: e08ffa8d56799c38e36aa94809df7db56fed8c69

[Martyn Gigg]

Fix gcc 4.8 warnings from API

Refs #9421

Changeset: 379c16c5c7e3643a806f2f530cd744ff212e048c

[Martyn Gigg]

Fix warnings about use of unitialized variabies in MantidNexus

Refs #9421

Changeset: 166f033414d419fe53a57468cd506b35e4089baf

[Michael Reuter]

I did this on my Fedora machine and it significantly reduced the warning numbers from ~420 to 15. Does not make it zero for me though.

[Martyn Gigg]

Thanks. I'll take another look.

[Martyn Gigg]

Kill gcc 4.8 warnings in tests.

Refs #9421

Changeset: 960708a4a26ff28e8c2e0a47b8ad2d5efd7436a1

[Martyn Gigg]

Fix numpy array writable flag setter.

Refs #9421

Changeset: c1e6b6c5de74212360a1ab5e581d8935a7abaae0

[Martyn Gigg]

Merge branch 'bugfix/9421_gcc4.8_numpy1.7_warnings' into develop

Conflicts:

Code/Mantid/Framework/DataObjects/test/ManagedWorkspace2DTest.h

Refs #9421

Changeset: 4c8727e8ff338e508f7e1709977def6d0d523e75

[Martyn Gigg]

Fix array initialization on VC++

Refs #9421

Changeset: 250177d68440d8deb7a3bce7770f73ceb5179d8a

[Martyn Gigg]

I think I've caught them all now.

Branch: ​bugfix/9421_gcc4.8_numpy1.7_warnings

Tester: Ideally this should be built clean on both Fedora 20 & Ubuntu 14.04 and all of the tests run but I think they both have gcc 4.8.2 & numpy 1.8 so either should be okay. The build should be clear of compiler warnings.

[Michael Reuter]

We're almost there, but both OSes are still showing the following warnings from UI components.

/home/2zr/git/mantidproject/mantid/Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui: Warning: The name 'label_5' (QLabel) is already in use, defaulting to 'label_51'.
/home/2zr/git/mantidproject/mantid/Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui: Warning: The name 'verticalLayout_4' (QVBoxLayout) is already in use, defaulting to 'verticalLayout_41'.
/home/2zr/git/mantidproject/mantid/Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui: Warning: The name 'label_4' (QLabel) is already in use, defaulting to 'label_41'.
/home/2zr/git/mantidproject/mantid/Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui: Warning: The name 'label_3' (QLabel) is already in use, defaulting to 'label_31'.
/home/2zr/git/mantidproject/mantid/Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui: Warning: Tab-stop assignment: 'ckCreateInfoTable' is not a valid widget.

[Martyn Gigg]

I see them now, my grep only caught the lower-case 'w' ones. They're not actually warnings from gcc but from the Qt uic compiler and are acutally in our other clean builds at the moment. I'll try and fix them nonetheless.

[Michael Reuter]

I'm fine with the explanation. You can close this ticket again and open one to fix the other issues since they are pre-existing but don't get flagged by the warning checkers.

[Martyn Gigg]

Fix uic warnings about duplicate names

Refs #9421

Changeset: 74316f79a6485d97f1bd0d71b8a2171b72a52dc4

[Martyn Gigg]

That should have fixed uic warnings those now.

[Michael Reuter]

Martyn, you are the best. All warnings are now gone.

[Michael Reuter]

Merge remote-tracking branch 'origin/bugfix/9421_gcc4.8_numpy1.7_warnings'

Full changeset: ​39aaa4f03d258a203694d958444f8c91d047d968

[Stuart Campbell]

This ticket has been transferred to github issue ​10264