Remove Mandatory Stitching Defaults

[Owen Arnold]

Since #9171. Stitch1D has been adapted so that most of the parameters are not mandatory. This relaxation has not been propagated to the following Algorithms:

• CreateTransmissionWorkspaceAuto
• ReflectometryReductionOneAuto

This is a necessary step for creating the new reflectometry gui.

[Owen Arnold]

refs #9470. Invoke error.

Changeset: 0b90f656935ef9c6402223ac2e6548391ca8e8e1

[Keith Brown]

added #9500 and #9501 as blockers here as the new C++ algs will need this update

[Owen Arnold]

Tester. The following python scripts should now work since Params, StartOverlap and EndOverlap are not mandatory.

LoadISISNexus(Filename='INTER000013463', OutputWorkspace='13463')
LoadISISNexus(Filename='INTER000013464', OutputWorkspace='13464')
 
transmission_new_style = CreateTransmissionWorkspaceAuto(
                                           FirstTransmissionRun='13463', 
                                           SecondTransmissionRun='13464')

# transmission_new_style should be a workspace in wavelength

Same for ReflectometryReductionOneAuto

LoadISISNexus(Filename='INTER000013463', OutputWorkspace='13463')
LoadISISNexus(Filename='INTER000013464', OutputWorkspace='13464')
run = LoadISISNexus(Filename='INTER000013460', OutputWorkspace='13460')
 
incidentAngle = 0.7
 
                                           
a, b, c = ReflectometryReductionOneAuto(InputWorkspace='13460',
                                           FirstTransmissionRun='13463', 
                                           SecondTransmissionRun='13464', ThetaIn=incidentAngle)
                                           
# a in q
# b in wavelength
# c is a double scale factor

Check that the workspaces are outputted in the correct X-units. Unit tests have already been added for these features.

No code changes to be made here, so no branch to build or merge . These relate to work that has already been done under #9785.

[Peter Parker]

Both scripts now work. The resulting workspaces had the expected units.

[Stuart Campbell]

This ticket has been transferred to github issue ​10313