New MVP Reflectometry GUI - Expand Table format for new fields

[Keith Brown]

there's a new field "options" that needs added and it's contents plugged into the params property of ReflectometryReductionOneAuto

The interface needs to be expanded to support this. The options column should come after the groups column.

The overrides should be expressed as key-value pairs. The key value paris should reflect the options in ReflectometryReductionOneAuto. It would be best to dynamically populate the allowed keys list based on the available ReflectometryReductionOneAuto property names, for example:

StartOverlap=0.1, EndOverlap=0.2

. Ensure we have unit tests to thoroughly verify this new behaviour We don't want to fully run the algorithm for each scenario, this would take too long, but we do need unit tests to ensure that Options are always set on the algorithm post init() and prior to execute(). The last thing we want is users complaining about some obscure scenario, where they can't overload options, I suggest introducing a new class for this, which would make the behaviour testable, and could be used within the presenter.

[Keith Brown]

not going to get this done before i leave, giving to owen

[Owen Arnold]

Ask me about this if not clear.

[Harry Jeffery]

Refs #9473 Add Options column

Add a blank options column to the Refl UI. It currently does nothing, but it will eventually allow options for the workflow algorithms to be overridden.

Changeset: 9af289b7d65a1fcd0db4fbf4fe22523ba14288ca

[Harry Jeffery]

Refs #9473 Add basic options parsing

Changeset: aac2d9ef148fb9cafe0be156f1037f1999ea14a4

[Harry Jeffery]

Merge branch 'master' into feature/9473_refl_add_options_column

Refs #9473

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ReflMainViewPresenter.h Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Changeset: 28929ed8b0e311825244f7585659994e239e204a

[Harry Jeffery]

Refs #9473 Fix failing unit test

Changeset: b8f1d1ad3c7a14a5583a1a83c9a382b625c4be05

[Martyn Gigg]

The unit tests still seem to be broken: ​http://builds.mantidproject.org/job/develop_incremental/label=ubuntu-14.04-build/1913/consoleFull.

There seems to be a clash with something that is already on develop.

I have removed the merge to develop from comment 7 onwards to fix the builds so that others can work and the nightly builds will pass.

[Harry Jeffery]

Refs #9473 Update LoadReflTBL unit test

Changeset: b35513d7457cb969c1c503c3d43e573a0d8d9c00

[Harry Jeffery]

Refs #9473 Improve error handling

Changeset: b6910d91830fe237583efe80bb5e945e257b6a7c

[Harry Jeffery]

Refs #9473 Fix compiler warning

Changeset: 2e6331ca76853d998d62e85dcc48588880ffb464

[Harry Jeffery]

Merge branch 'master' into feature/9473_refl_add_options_column

Refs #9473

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ReflMainViewPresenter.h Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Full changeset: ​28929ed8b0e311825244f7585659994e239e204a

[Owen Arnold]

refs #9473. Fix merge conflicts.

Merge remote-tracking branch 'origin/feature/9473_refl_add_options_column'

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Changeset: 97360d236901072ee8f405a2938fb322f1d3a22e

[Stuart Campbell]

This ticket has been transferred to github issue ​10316