Ticket #9483 (closed: fixed)
Remove using directives from headers
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description (last modified by Peter Peterson) (diff)
It is just bad form and pollutes the code. To finf those in Framework (on linux):
ag ^\\s\*using -G /inc/.+\\.h ~/code/mantid/Code/Mantid/Framework/
Change History
comment:1 Changed 6 years ago by Peter Peterson
- Status changed from new to assigned
- Description modified (diff)
comment:7 Changed 6 years ago by Pete Peterson
- Status changed from assigned to inprogress
Re #9483. Removing using directives from headers.
Changeset: 2d01a32f1547c8947062778fcbb704a7381a106f
comment:8 Changed 6 years ago by Pete Peterson
Re #9483. Removing using directives from headers.
Changeset: ae7b5634c176c45303dc3bf553284996dd404370
comment:9 Changed 6 years ago by Pete Peterson
Re #9483. Moving code from header to source file.
Changeset: 40f628babc7151eef37c5b08e088377556d9ecda
comment:10 Changed 6 years ago by Pete Peterson
Re #9483. Droped many more using directives from headers.
Changeset: 2795c8566255e3db20bb5fc731fa67e7d7a67a4b
comment:11 Changed 6 years ago by Pete Peterson
Re #9483. Fixing unit tests that don't compile.
Changeset: 57e1f77da81549c9c12010c4465dfab0c08dfc61
comment:12 Changed 6 years ago by Pete Peterson
Re #9483. Getting rid of cppcheck warnings.
Changeset: c7ed5db48f8385ca7590435857ff847efaa71c31
comment:13 Changed 6 years ago by Pete Peterson
Re #9483. Getting rid of doxygen warnings.
Changeset: 8f2acc51ee9e22f78e41b30d441fb3f6c9833fd0
comment:14 Changed 6 years ago by Pete Peterson
Re #9483. Getting rid of doxygen warnings.
Changeset: edcfa85716f197f3650d07f8df4d10bb8019f214
comment:15 Changed 6 years ago by Pete Peterson
Re #9483. Getting rid of doxygen warnings.
Changeset: 7f517831fd5128da1a158ab8d2b27229f9e2a587
comment:16 Changed 6 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
- Description modified (diff)
This is on feature/9483_using_headers.
To test: Look at the diff and see that everything still builds. There are lots of files that will still be found using the silver-searcher command. Those are either in the python bindings, or required to quiet the intel compiler when selecting which parent's implementation to use.
comment:17 Changed 6 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:18 Changed 6 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9483_using_headers'
Full changeset: 2fec5cd3b165e6fbd61300e425c94d703f7015d3
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10326
