Context Navigation

Ticket #9511 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

New chunking determination

Reported by:	Peter Peterson	Owned by:	Peter Peterson
Priority:	critical	Milestone:	Release 3.2
Component:	Framework	Keywords:
Cc:		Blocked By:	#9523
Blocking:	#9537	Tester:	Vickie Lynch

Description

The current DetermineChunking algorithm (for event nexus files) creates chunks that are of equal size and applicable for that file. This makes processing portions of the instrument impossible (i.e. sample minus background). Create a new algorithm that will take a level of the instrument and generate a chunking strategy from that. This only needs to support event nexus files from powder instruments (e.g. POWGEN and NOMAD) for now.

Change History

comment:1 Changed 6 years ago by Peter Peterson

Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Peterson

Blocking 9537 added

comment:3 Changed 6 years ago by Pete Peterson

Status changed from assigned to inprogress

Re #9511. Modified class_maker to output compilable algorithms.

Changeset: e70110ad94a7b0cfc83bbdfda572069de05a348f

comment:4 Changed 6 years ago by Pete Peterson

Re #9511. First version that compiles.

Changeset: 1b800baa7a007a9ff45333c00f37e015e81a11a0

comment:5 Changed 6 years ago by Pete Peterson

Re #9511. First version that works for one case.

Changeset: f178d9a370e53f2bfe7c072ffa454214a168507e

comment:6 Changed 6 years ago by Pete Peterson

Re #9511. Made instrument declaration a parameter.

Changeset: 7adc7771d8bb58b15999519def364500e269e2e4

comment:7 Changed 6 years ago by Pete Peterson

Re #9511. Moved the instrument loading into a separate method.

Changeset: 879feaec400aa074512c4c227ab17e4365d09b3f

comment:8 Changed 6 years ago by Pete Peterson

Re #9511. Adding meaningful unit tests.

Changeset: 3fe3488394abca3feb5491d252d834c89c939544

comment:9 Changed 6 years ago by Pete Peterson

Re #9511. No need to deal with instrument name special cases.

Changeset: dc9b76e12f7cff37f477cec3b017c1610f38c14e

comment:10 Changed 6 years ago by Pete Peterson

Re #9511. Filling in algorithm documentation.

Changeset: ad2722c1ef8baed9ff3d14ae47bca7464c77ed6f

comment:11 Changed 6 years ago by Pete Peterson

Merge branch 'feature/9511_create_chunking' into develop

Re #9511 Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt

Changeset: 4a4e98ce69cfa60dfb3f7ae43278c3b43479f455

comment:12 Changed 6 years ago by Peter Peterson

Status changed from inprogress to verify
Resolution set to fixed

This is on feature/9511_create_chunking

To test: Since this really only works on instruments with components named "bank#", you'll have to try with some of those. Specifically: NOMAD, POWGEN, and SNAP.