Ticket #9546 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix SCD reduction problems

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Default on AllowPermutations should be true not false. Also getting error that ls files cannot be overwritten when rerunning after broken pipe.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Look at error for Monoclinic P in log to see if this is fixed. It should be less than 0.04. Also check that AllowPermutations works on 4th tab of SCD Event Data Reduction Interface 

######################################################################
#Python Script Generated by GeneratePythonScript Algorithm
######################################################################
Load(Filename=r'/SNS/TOPAZ/IPTS-10321/0/9765/NeXus/TOPAZ_9765_event.nxs',OutputWorkspace='TOPAZ_9765_event',LoadMonitors='1')
ConvertToMD(InputWorkspace='TOPAZ_9765_event',QDimensions='Q3D',dEAnalysisMode='Elastic',Q3DFrames='Q_sample',LorentzCorrection='1',OutputWorkspace='TOPAZ_9765_md',MinValues='-25,-25,-25',MaxValues='25,25,25',SplitInto='2',SplitThreshold='50',MaxRecursionDepth='13',MinRecursionDepth='7')
FindPeaksMD(InputWorkspace='TOPAZ_9765_md',PeakDistanceThreshold='0.12559999999999999',MaxPeaks='50',DensityThresholdFactor='100',OutputWorkspace='TOPAZ_9765_peaks')
LoadIsawUB(InputWorkspace='TOPAZ_9765_peaks',Filename=r'/SNS/TOPAZ/IPTS-10321/shared/xtal2vial1_e09_b002/merge.mat')
IndexPeaks(PeaksWorkspace='TOPAZ_9765_peaks',Tolerance='0.12')
SelectCellOfType(PeaksWorkspace='TOPAZ_9765_peaks',CellType='Monoclinic',Apply='1')
Last edited 6 years ago by Vickie Lynch (previous) (diff)

comment:2 Changed 6 years ago by Vickie Lynch

  • Summary changed from Fix SCD reduction proglems to Fix SCD reduction problems

comment:3 Changed 6 years ago by Vickie Lynch

Refs #9546 option for AllowPermutations with default of true

Changeset: 84e983f996d5ccd78563dbaaa5af092f431dff3e

comment:4 Changed 6 years ago by Vickie Lynch

Refs #9546 only write ls files when PerRun is checked

Changeset: f3180eff4ca65942e34073d4db3c79b3d15c836f

comment:5 Changed 6 years ago by Vickie Lynch

  • Status changed from new to assigned

To Test second commit:

{{ LoadIsawPeaks(Filename=r'/SNS/TOPAZ/shared/Sapphire/2mmSapphire.peaks',OutputWorkspace='Sapphire') LoadIsawUB(InputWorkspace='Sapphire',Filename=r'/SNS/TOPAZ/shared/Sapphire/2mm.mat') OptimizeLatticeForCellType(PeaksWorkspace='Sapphire',CellType='Hexagonal',Apply='1') OptimizeLatticeForCellType(PeaksWorkspace='Sapphire',CellType='Hexagonal',Apply='1',PerRun='1') }}}

comment:6 Changed 6 years ago by Vickie Lynch

  • Cc petersonpf@… added
  • Status changed from assigned to verify
  • Resolution set to fixed

These changes should fix the problems Mads and Christina were having with user's data this week.

comment:7 Changed 6 years ago by Vickie Lynch

  • Milestone changed from Backlog to Release 3.2

comment:8 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:9 Changed 6 years ago by Wenduo Zhou

Well done. Ticket is thus closed.

comment:10 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9546_SCD_reduction'

Full changeset: ​dee5c4e8a15dabf7222bb27978bc71cef74abcee

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10389

Note: See TracTickets for help on using tickets.