Ticket #9550 (closed: fixed)
Make Sure We Correctly Deduce Instrument Name in FileFinder For SANS2D Data Files
| Reported by: | Peter Parker | Owned by: | Peter Parker |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
For SANS2D data files (and possibly other instruments), we have a situation in FileFinder where we fail to correctly parse the instrument name from the file name. For SANS2D runs, it has actually been thinking the instrument was SANS at the LENS facility!
Up until now, this problem has only ever manifested itself as the data archive search not working for SANS2D (as LENS does not have an archive search registered with Mantid), and this has gone unnoticed for so long since Richard Heenan only ever loads his data from a mapped network drive which he has also added as a Managed Directory.
Martyn has pointed out that #7515 exists to implement a FileFinder redesign, but in the meantime an acceptable fix would be to simply extend the hack that was introduced for PG3. This means manually checking for "SANS2D" at the start of the file name, rather than just finding the first digit and the chopping off the rest of the string.
While I'm doing this, I will make sure there aren't any other problematic instrument names we aren't aware of.
Change History
comment:3 Changed 6 years ago by Peter Parker
- Status changed from assigned to verify
- Resolution set to fixed
Turns out there are lot's of problematic instrument names (the ILL instruments for example), but I'm just going to limit the scope of this ticket to SANS2D. #7515 will sort out the rest.
To test:
Make sure you can reproduce the problem by turning on archive data searching and then passing "SANS2D00023792.nxs" or similar to the Load algorithm. It should fail to find the file.
Merge in the changes and try the same thing again. The file should load without any problems.
comment:4 Changed 6 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:5 Changed 6 years ago by Jay Rainey
- Status changed from verifying to reopened
- Resolution fixed deleted
Needs re-merged to develop.
comment:6 Changed 6 years ago by Peter Parker
- Status changed from reopened to verify
- Resolution set to fixed
Re-merged.
comment:8 Changed 6 years ago by Jay Rainey
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9550_support_sans2d_archive_searching'
Full changeset: 62e91d0d51a6b1e456b42e01252ac40d71899573
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10393
Refs #9550 - Fully support SANS2D in FileFinder.
Covered this edge case with a unit test. Added a comment to discourage further extensions to this hack.
Changeset: efbec8d63c020b09df5b7fa22a49a13a8588e7a4