Ticket #9551 (closed: fixed)
Make integration time compulsory
| Reported by: | Arturs Bekasovs | Owned by: | Raquel Alvarez Banos |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.4 |
| Component: | Muon | Keywords: | ALC |
| Cc: | jamie.peck@… | Blocked By: | #9489 |
| Blocking: | Tester: | Karl Palmen |
Description
As Stephen requested, remove the check-box and complain if it wasn't specified.
In the future should come up with good starting values, but for now set to 0.
Change History
comment:2 Changed 6 years ago by Pete Peterson
- Status changed from assigned to inprogress
Re #9551. Adding bad weather tests and fixing algorithm.
Changeset: 6bdfc5525ec8bf4533372b3bbefb454691d710db
comment:4 Changed 6 years ago by Nick Draper
- Owner changed from Arturs Bekasovs to Anders Markvardsen
comment:5 Changed 6 years ago by Anders Markvardsen
- Milestone changed from Release 3.2 to Release 3.3
comment:6 Changed 6 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Karl Palmen
comment:7 Changed 6 years ago by Karl Palmen
The checkbox is the Time Limit checkbox in the 'data loading' view. On removal its value is treated as true and the default times are kept at 0.0 and 0.0. Warn user before proceeding with Load, if this range remains zero duration and don't proceed with load unit a positive time interval has been provided.
comment:9 Changed 6 years ago by Karl Palmen
Make time interval compulsory re #9551
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d4e6903121b8b513c006cbb291e572f28a1be5fb
comment:10 Changed 6 years ago by Karl Palmen
Set time range in unit test to (-6,32) re #9551
This causes the tests to pass, but it may not be legitimate.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 63862fec8f0d0a4d0d06226075d6af575e8a3496
comment:11 Changed 6 years ago by Nick Draper
- Milestone changed from Release 3.3 to Release 3.4
Moved to R3.4
comment:12 Changed 6 years ago by Anders Markvardsen
- Owner changed from Karl Palmen to Raquel Alvarez Banos
Please do not hesitate to ask Karl about the commits made to this ticket
comment:15 Changed 6 years ago by Raquel Alvarez Banos
Re #9551 Remove check box and enable time limits
Changeset: 66a14693d5249020e58ba4bf8bbc8acff3c06416
comment:16 Changed 6 years ago by Raquel Alvarez Banos
Re #9551 Check time limits
Changeset: 1261a032a7a3c54f198fd892e54d1df04da5c8f6
comment:17 Changed 6 years ago by Raquel Alvarez Banos
Re #9551 Set time limits in unit test
Changeset: 7016dc9c23f4e645e77cc926b5193aaafe126aa2
comment:18 Changed 6 years ago by Raquel Alvarez
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #421.
comment:19 Changed 6 years ago by Raquel Alvarez Banos
Re #9551 Fix compiler warning
Changeset: d5ac88a6f405052cc62b2513f5d9b483a1476790
comment:20 Changed 6 years ago by Raquel Alvarez Banos
Re #9551 Previous fix did not work, try again
Changeset: f43ae203e364aa478b04ef0c33b9369c4ca444a5
comment:21 Changed 6 years ago by Raquel Alvarez
Jenkins, retest this please
comment:22 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:23 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge pull request #421 from mantidproject/9551_make_integration_time_compulsory
Make integration time compulsory
Full changeset: f4156e6883893cce829b9c87ed5377ee2ffb3c76
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10394
