Ticket #9643 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Create an algorithm to load VULCAN's calibration file

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Wenduo Zhou) (diff)

VULCAN has its own calibration file to do time focusing. The idea is somehow similar as that in Mantid, but it works in TOF but not d-spacing. Write a new algorithm similar to LoadCalFile() to load VULCAN's offset file, DIFC file and bad pixel file.

A discrepancy of the naming of banks between Mantid and current VUCLAN's IDL code is found. Modify the geometry file to make it consistent.

Attachments

verify9643.py​ (8.9 KB) - added by Wenduo Zhou 6 years ago.
pid_offset_vulcan_new.dat​ (1.3 MB) - added by Wenduo Zhou 6 years ago.
mod_difc_vulcan_new.dat​ (2.7 KB) - added by Wenduo Zhou 6 years ago.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to infoneeded
  • Milestone changed from Backlog to Release 3.3

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from infoneeded to new

comment:3 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

comment:5 Changed 6 years ago by Wenduo Zhou

Added partially finished new algorithm. Refs #9643.

Changeset: 5d9aa2c2da34036ae66a8be1565e0c5980e83a80

comment:6 Changed 6 years ago by Wenduo Zhou

  • Description modified (diff)

comment:7 Changed 6 years ago by Wenduo Zhou

Refs #9643. Implemented the conversion from VULCAN offset to Mantid.

Also, the geometry file of VULCAN is slightly modified to make the definition of bank numbers consistent between Mantid and that VULCAN uses now.

A unit test data file is added, too.

Changeset: cb1617640d1286b88e1fa38c758a70aac89d94ec

comment:8 Changed 6 years ago by Wenduo Zhou

Fixed some issues during completing unit tests. Refs #9643.

Changeset: 4059ed68df5c78c0c1f493f7eb1bf71183134d68

comment:9 Changed 6 years ago by Wenduo Zhou

Refs #9643. Fixed errors and warnings.

Including Windows, Mac, Doxygen and CppCheck.

Changeset: a5cd27ee384068039ccbd877e4cf22f4c035303b

comment:10 Changed 6 years ago by Wenduo Zhou

Enabled to import mask file. Refs #9643.

Also

  1. Add unit test file;
  2. Write a new unit test for it;

Changeset: 7031e9329538bc6e8449ee15c0d219040fdfd169

comment:11 Changed 6 years ago by Wenduo Zhou

Added partially finished new algorithm. Refs #9643.

Changeset: 02d725ad08fa9e73b902c69a346fdc8045bf3735

comment:12 Changed 6 years ago by Wenduo Zhou

Refs #9643. Implemented the conversion from VULCAN offset to Mantid.

Also, the geometry file of VULCAN is slightly modified to make the definition of bank numbers consistent between Mantid and that VULCAN uses now.

A unit test data file is added, too.

Changeset: d0b66ba57a41dbd5295b2db5cb0d3e1bb94a614f

comment:13 Changed 6 years ago by Wenduo Zhou

Fixed some issues during completing unit tests. Refs #9643.

Changeset: ef36d1d39b1b8ca95dc2859dcc62d10e29ac282e

comment:14 Changed 6 years ago by Wenduo Zhou

Refs #9643. Fixed errors and warnings.

Including Windows, Mac, Doxygen and CppCheck.

Changeset: 4f067ab68d03724cfc746fe5a427c049bdd446ae

comment:15 Changed 6 years ago by Wenduo Zhou

Enabled to import mask file. Refs #9643.

Also

  1. Add unit test file;
  2. Write a new unit test for it;

Changeset: 04076ebc49fc77f5b7f1f139c3ef95d3766feb6b

comment:16 Changed 6 years ago by Wenduo Zhou

Fixed some issues. Refs #9643.

Including

  1. sphinx documentation due to change of geometry file;
  2. added unit test file again due to rebasing with master;
  3. cppcheck warning.

Changeset: 872315475803fc927c6c20491ae4f4713446caf9

comment:17 Changed 6 years ago by Wenduo Zhou

Refs #9643. Fixed conflicts and others.

Conflicts:

Test/AutoTestData/pid_offset_vulcan_new.dat

And

  1. Rebased by master;
  2. Fixed cppcheck warnings;
  3. Fixed a sphinx doc error due to change in definition of bank ID.

Changeset: 8d324c2873c3fcc87fb42476771c468fbe354e03

comment:18 Changed 6 years ago by Wenduo Zhou

Refs #9643. Forgot to add to commit.

Changeset: 0a3564192a789cebdb9943d876a4d45527efdb47

comment:19 Changed 6 years ago by Wenduo Zhou

Fixed a git issue with unit test file. Refs #9643.

Changeset: ec43af5c112c971328fb557f087607ba718dccaa

comment:20 Changed 6 years ago by Wenduo Zhou

Refs #9643. Tried to fix windows warning.

Changeset: 4306a1c84f943a9f71a8830cde856ba59a9f9ca9

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

comment:21 Changed 6 years ago by Wenduo Zhou

Refs #9643. Added doc file.

Changeset: 20a92da9a8428e1670ec4fb6ad39275ae2789a8d

comment:22 Changed 6 years ago by Wenduo Zhou

Refs #9643. Fixed doc errors.

Changeset: 7627f22f7315f074b5502239107507e53552678b

comment:23 Changed 6 years ago by Martyn Gigg

Fix index error in vector access.

This was discovered by the windows debug build. Refs #9643

Changeset: ac1eafbdb19d87a1e016f8fffa84ff16e01247d5

comment:24 Changed 6 years ago by Wenduo Zhou

Added one more output workspace. Refs #9643.

Changeset: 3c045eabebee1dbcd5c0a2fa9c8811d221c14731

comment:25 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:26 Changed 6 years ago by Wenduo Zhou

Refs #9643. Updated unit test.

(1) Unit test is updated to remove the extra output workspace.

(2) Debugging output is cleaned up.

Changeset: 7f07600b88d00cc89c0c255a899c5acc7376a44e

comment:27 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:28 Changed 6 years ago by Vickie Lynch

Refs #9643 fix conflict

Changeset: cef03e948a85952bcbe3ed144464f81677b6e9da

comment:29 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

LoadDspacemap should be removed in another ticket since this algorithm does the same thing with more options.

comment:30 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10486

Note: See TracTickets for help on using tickets.