Fury bin width should only allow factors of bin range.

[Samuel Jackson]

Currently the bin width used can be set to anything, which can be fairly annoying for users. I've had a couple of requests to make it only allow input that is a factor of the ranges.

[Nick Draper]

Moved to Backlog at the code freeze of release 3.2

[Dan Nixon]

Added error message when bin width is not factor of bin range

Refs #9689

Changeset: c7de6418f9b8f54bfa18a3d101e3646b8706114c

[Dan Nixon]

Change bin width to fit 10 bins when a range end is changed

Ensured width always holds a valid value

Refs #9689

Changeset: a132e17c513ece41d5c8ebabbe27d7b68ef75172

[Dan Nixon]

Made Fury rebin param validation a little smoother

Will attempt to maintain a valid set of values as close as possible to any invalid values entered

Refs #9689

Changeset: 3cbd846ac971aefd7ec9eb0726dd0afe6712c7cb

[Dan Nixon]

To test:

• Open Indirect Data Analysis >> Fury
• Attempt setting the rebin range and bin width
• Notice that the bin width will default to the nearest factor of the range when a value is entered that is not a factor
• he same should also happen when a new range is entered

[Dan Nixon]

Just use warning message box

Refs #9689

Changeset: 58bf487db6df74262f36654228088e7df0fcdcbd

[Roman Tolchenov]

Tested on win7. After entering a wrong value I get a message but the value doesn't change to a valid one.

[Dan Nixon]

My mistake, I haven't updated the testing instructions.

After discussing this with Spencer it was thought to be best to just give a warning instead of trying to find an appropriate bin width. What you describe sounds like what should happen assuming the message appears in an information box.

[Roman Tolchenov]

Is the bin width difficult to calculate? Did you consider using a number of bins instead?

[Dan Nixon]

Work in progress, adding new binning options to Fury

Refs #9689

Changeset: c681e4cf3d216f44e2846d42c0f7f6edcc584c2c

[Dan Nixon]

Checkpoint: added new Fury algorithm

Refs #9689

Changeset: e81c94760c42225d53d4ff5c811096938c36d23e

[Dan Nixon]

Added docs for Fury algorithm

Refs #9689

Changeset: 5c1739be35cded9e2388f427ae70fd45671ef56f

[Dan Nixon]

Use new Fury algorithm on IDA:Fury interface

Refs #9689

Changeset: 588e018c2a3ad1326df35d49cbd8166f2abb5d8f

[Dan Nixon]

Merge branch 'bugfix/9689_only_allow_factors_of_range_in_fury_bin_width' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui

Refs #9689

Changeset: 729d2d26299af956eefbca4411795b20006377bf

[Dan Nixon]

Get resolution from IPF, little Qt signal refactoring

Refs #9689

Changeset: f1cc077df7eac7bd95838d5854678e3066568e63

[Dan Nixon]

Moved res bin calculation to algorithm, small corrections

Refs #9689

Changeset: 0bfa39de9a8fa4e426ead11dee5b394de7aa63f7

[Dan Nixon]

Enable range selector movement

Refs #9689

Changeset: f4944f2dcee0c558cf6912b910406e88b6242791

[Dan Nixon]

Merge branch 'master' into bugfix/9689_only_allow_factors_of_range_in_fury_bin_width

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui

Refs #9689

Changeset: 3885e9d9ea0b7f29f7abda44a5bdb0894e4f2379

[Dan Nixon]

Disable info only properties, added validation to algorithm

Refs #9689

Changeset: 551dc9e3f94ccfd039f1501ebffe9df22e616c2d

[Dan Nixon]

Added sample logs, Python refactoring

Refs #9689

Changeset: 1bb07341560961fce16e07d03cd259405f621122

[Dan Nixon]

Link ELow and EHigh on Fury

Refs #9689

Changeset: 4f10274baad24a4b6cd5f363d4780cd5b2f9f507

[Dan Nixon]

Only recalculate values when range selector is relased

Refs #9689

Changeset: b950f44d5cffd85cb5674ad89ad484cfdf588568

[Dan Nixon]

Give warning when fury resolution bins < 5

Refs #9689

Changeset: ef7481bc67b620f97e6ec7da029d46dd7ca369bf

[Dan Nixon]

Move res bins warning to be shown after changing values

Refs #9689

Changeset: 21a2743db87f1d373ed960ce9ca435c74532199e

[Dan Nixon]

New to test:

• Open Indirect > Data Analysis > Fury
• Load a sample file (e.g. irs26173_graphite002_red.nxs from system tests)
• Load a resolution file (e.g. irs26173_graphite002_res.nxs from system tests)
• Move the range selectors and notice the binning recalculation when they are released
• Increase the sample binning such that the number resolution bins drops below 5, this should give a warning
• Run fury, open the sample logs for the *_iqt workspace and check that the fury_rebin_* entries match the ELow, EHigh and EWidth values in the UI

[Anders Markvardsen]

Ups only just noticed Roman in the progress of testing this one. Returned in to testing pull

[Dan Nixon]

Merge branch 'master' into bugfix/9689_only_allow_factors_of_range_in_fury_bin_width

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui Code/Mantid/MantidQt/CustomInterfaces/src/FuryFit.cpp

Full changeset: ​3669e6870a8348a260f49ecdd06ae78140cee40f

[Dan Nixon]

Merge branch 'master' into bugfix/9689_only_allow_factors_of_range_in_fury_bin_width

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui

Refs #9689

Full changeset: ​3885e9d9ea0b7f29f7abda44a5bdb0894e4f2379

[Martyn Gigg]

Merge branch 'bugfix/9689_only_allow_factors_of_range_in_fury_bin_width'

Full changeset: ​fe97d5fd6a54e4491a4c3ec107dfe19332ead0b7

[Stuart Campbell]

This ticket has been transferred to github issue ​10531