Ticket #9773 (closed: worksforme)

Opened 6 years ago

Last modified 5 years ago

Doctest failures on windows

Reported by: Keith Brown Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.4
Component: Documentation Keywords:
Cc: anders.markvardsen@… Blocked By: #9823
Blocking: Tester: Federico M Pouzols

Description

The following rst files fail tests when run on windows

ExportSampleLogsToCSVFile-v1 EnginXFitPeaks-v1 ExportExperimentLog-v1 FixGSASInstrumentFile-v1

Change History

comment:1 Changed 6 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Karl Palmen

  • Cc anders.markvardsen@… added

comment:3 Changed 6 years ago by Karl Palmen

These four rst files are amongst the 9 that don't work on my machine.

comment:4 Changed 6 years ago by Karl Palmen

ExportSampleLogsToCSVFile-v1 and ExportExperimentLog-v1 fail because of a disagreement about the number of bytes in the output file. This should not be tested for ASCII files, because it is system dependent.

comment:5 Changed 6 years ago by Karl Palmen

The usage example of SaveCSV does not test the output file

  import os
  # Create a file path in the user home directory
  filePath = os.path.expanduser('~/SavedCSVFile.csv')

  # Create a workspace
  ws=CreateSampleWorkspace()
  # Save it in Nexus format
  SaveCSV(ws,filePath)

comment:6 Changed 6 years ago by Karl Palmen

Both ExportSampleLogsToCSVFile-v1 and ExportExperimentLog-v1 output to CSV files. I'll create a new ticket for them.

comment:7 Changed 6 years ago by Karl Palmen

  • Blocked By 9823 added

comment:8 Changed 6 years ago by Karl Palmen

Comment belongs to #9823

Last edited 6 years ago by Karl Palmen (previous) (diff)

comment:9 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Karl Palmen to Anders Markvardsen
  • Status changed from assigned to verify
  • Resolution set to worksforme
  • Milestone changed from Backlog to Release 3.4

comment:10 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:11 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

This seems to have been fixed. I didn't see any errors, and there have been no issues in the last builds' doctests in any platforms.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10615

Note: See TracTickets for help on using tickets.