Ticket #9884 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

EQSANS: always save reduction parameters

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.3
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The EQSANS team would like to have the reduction parameters saved in the output CanSas XML file.

At the moment, the reduction parameters are only saved in the CanSas file when the reduction is started from the UI. Now that all the reduction properties go through SetupEQSANSReduction, it would be possible to extend that to all reductions, regardless of whether the UI was used to start them.

Change History

comment:1 Changed 6 years ago by Mathieu Doucet

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Mathieu Doucet

  • Status changed from assigned to inprogress

Re #9884 Add string repr of setup algorithm to prop manager

Changeset: 440ec9fe25dc68d1b3f9a597146dbdd891e7a5fc

comment:3 Changed 6 years ago by Mathieu Doucet

Re #9884 add setup algorithm string to xml output

Changeset: 49042a358c4676c1c15dd129a04d431f52524d8e

comment:4 Changed 6 years ago by Mathieu Doucet

Re #9884 added load from setup information

Changeset: 18a468b652c9b647e07a91801f1fb04059239f04

comment:5 Changed 6 years ago by Mathieu Doucet

Re #9884 set up background options

Changeset: ec847ff5f0a96c02fc4e29ee902817d89030fab8

comment:6 Changed 6 years ago by Mathieu Doucet

Re #9884 Add eqsans setup info

Changeset: 529e169c101cb962f8356002290d7c1d5c85b11b

comment:7 Changed 6 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Start the EQSANS reduction UI and set up a reduction.
  • Export the reduction to a python script.
  • Run the script outside of the UI and try to load the xml I(q) output in the UI. You should be able to see all the reduction options populated in the UI.
  • Modify the reduction script, run it outside the reduction UI, and load the output xml in the UI to verify that your changes are properly populated in the UI.
  • Repeat until you have gone through enough options to be satisfied...

comment:8 Changed 6 years ago by Peter Parker

  • Milestone changed from Backlog to Release 3.3

comment:9 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:10 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9884_save_ornl_sans_parameters'

Full changeset: 061c6798640e210bb79194a5dc6e0e379fbb7ef0

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10726

Note: See TracTickets for help on using tickets.